CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sat Sep 26 16:00:12 UTC 2020

Modified Files:
        src/usr.bin/make: arch.c compat.c cond.c job.c main.c make.c make.h
            nonints.h parse.c suff.c targ.c var.c

Log Message:
make(1): clean up API for finding and creating GNodes

The previous API had complicated rules for the cases in which the single
function returned NULL or what it did.  The flags for that function were
confusing since passing TARG_NOHASH would create a new node even though
TARG_CREATE was not included in that bit mask.

Splitting the function into 3 separate functions avoids this confusion.
It also reveals several places where the complicated API led to
unreachable code.  Such code has been removed.


To generate a diff of this commit:
cvs rdiff -u -r1.122 -r1.123 src/usr.bin/make/arch.c
cvs rdiff -u -r1.150 -r1.151 src/usr.bin/make/compat.c
cvs rdiff -u -r1.151 -r1.152 src/usr.bin/make/cond.c
cvs rdiff -u -r1.238 -r1.239 src/usr.bin/make/job.c
cvs rdiff -u -r1.345 -r1.346 src/usr.bin/make/main.c
cvs rdiff -u -r1.144 -r1.145 src/usr.bin/make/make.c
cvs rdiff -u -r1.146 -r1.147 src/usr.bin/make/make.h
cvs rdiff -u -r1.129 -r1.130 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.331 -r1.332 src/usr.bin/make/parse.c
cvs rdiff -u -r1.167 -r1.168 src/usr.bin/make/suff.c
cvs rdiff -u -r1.94 -r1.95 src/usr.bin/make/targ.c
cvs rdiff -u -r1.542 -r1.543 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.