CVS commit: src/sys

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    src
Committed By:   riastradh
Date:           Fri Dec 31 14:19:57 UTC 2021

Modified Files:
        src/sys/dev/wscons: wsdisplay.c
        src/sys/kern: subr_autoconf.c subr_psref.c subr_thmap.c
        src/sys/lib/libkern: libkern.h

Log Message:
libkern: Make KASSERT verify expression is valid if !DIAGNOSTIC.

This way it is no longer necessary to mark variables __diagused if
they are used in KASSERT conditions.

Fix fallout from this by removing now-unnecessary and `#ifdef
DIAGNOSTIC'.

Don't do the same for KDASSERT if !DEBUG -- unlike KASSERT and
DIAGNOSTIC, variables needed by KDASSERT and DEBUG are likely to be
expensive to compute (and potentially difficult for a compiler to
prove flushable), so we don't want to require them under !DEBUG.


To generate a diff of this commit:
cvs rdiff -u -r1.162 -r1.163 src/sys/dev/wscons/wsdisplay.c
cvs rdiff -u -r1.290 -r1.291 src/sys/kern/subr_autoconf.c
cvs rdiff -u -r1.15 -r1.16 src/sys/kern/subr_psref.c
cvs rdiff -u -r1.7 -r1.8 src/sys/kern/subr_thmap.c
cvs rdiff -u -r1.143 -r1.144 src/sys/lib/libkern/libkern.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.