CVS commit: src

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    src
Committed By:   riastradh
Date:           Sun May 22 11:40:04 UTC 2022

Modified Files:
        src/share/man/man9: opencrypto.9
        src/sys/netipsec: xform_ah.c xform_esp.c xform_ipcomp.c
        src/sys/opencrypto: crypto.c cryptodev.c cryptodev.h

Log Message:
opencrypto: Rip out EAGAIN logic when unregistering crypto drivers.

I'm pretty sure this never worked reliably based on code inspection,
and it's unlikely to have ever been tested because it only applies
when unregistering a driver -- but we have no crypto drivers for
removable devices, so it would only apply if we went out of our way
to trigger detach with drvctl.

Instead, just make the operation fail with ENODEV, and remove all the
callback logic to resubmit the request on EAGAIN.  (Maybe this should
be ENXIO, but crypto_kdispatch already does ENODEV.)


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/share/man/man9/opencrypto.9
cvs rdiff -u -r1.112 -r1.113 src/sys/netipsec/xform_ah.c
cvs rdiff -u -r1.103 -r1.104 src/sys/netipsec/xform_esp.c
cvs rdiff -u -r1.72 -r1.73 src/sys/netipsec/xform_ipcomp.c
cvs rdiff -u -r1.126 -r1.127 src/sys/opencrypto/crypto.c
cvs rdiff -u -r1.121 -r1.122 src/sys/opencrypto/cryptodev.c
cvs rdiff -u -r1.48 -r1.49 src/sys/opencrypto/cryptodev.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.