CVS commit: src/share/mk

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sun Jul 10 21:16:58 UTC 2022

Modified Files:
        src/share/mk: bsd.subdir.mk

Log Message:
bsd.subdir.mk: remove practically dead code

The condition '${dir:H} != ""' is almost always satisfied, since 2001 at
least.  The only input for the modifier ':H' that leads to an empty
string is "/".  It doesn't make sense though to specify the root
directory as a subdirectory.

While here, remove quotes around the left-hand side of comparisons in
conditions.  The quotes have become redundant in 2008, when the .for
loop stopped inserting raw text into the .for loop body.

If the special case for "/" had actually been intended, it should have
been written as the equivalent '.if ${dir} == "/"' instead of hiding
this feature behind an edge case behavior of the modifier ':H'.

Based on the comments, the condition should have been '${dir:M/*}', but
it hadn't been written that way.


To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55 src/share/mk/bsd.subdir.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.