CVS commit: [netbsd-8] src/sys/netatalk

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Mon Jul 31 16:16:05 UTC 2023

Modified Files:
        src/sys/netatalk [netbsd-8]: at_control.c

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1866):

        sys/netatalk/at_control.c: revision 1.44

atalk(4): Don't let userland control sa_len when adding addresses.
- The struct sockaddr_at object accessed by at_ifinit always comes
  from an ioctl buffer that is adequately sized and fully initialized
  from userland memory.
- The newly created sockaddr_at object is later used with
  sockaddr_copy, which requires sa_len to be correctly initialized.
- sa_len is not generally required to be correctly initialized by
  userland in most entry points (with some exceptions, e.g. gif(4)
  configuration).

I don't know whether existing userland programs initialize sa_len
correctly; if they do, we can verify it matches sizeof(struct
sockaddr_at), but there's no need to copy sa_len then if it is
verified to be that fixed value.


To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.39.8.1 src/sys/netatalk/at_control.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.