tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: m68k: cache fpu result



On Tue, 8 Apr 2025 22:26:41 Martin Husemann wrote:
> On Tue, Apr 08, 2025 at 10:15:19PM +1000, Nat Sloss wrote:
> > I like to add the following patch which does two things:
> > 
> > 1) Add nop before fnop in fpu_probe() for buggy lc040 compatability
> 
> That will do no harm as it only runs once during initialization.
> 
> > 2) Caches the fpu result so the probe is only run once (in theory should
> > make the code a little faster)
> > 
> > http://ftp.netbsd.org/pub/NetBSD/misc/nat/m68k-fpu.c.diff
> 
> Isn't that function called exactly once during cpu initialization and the
> result cached in "fputype"? So adding another cache is not needed.
> 
> Martin

Fair enough, sorry I was unaware that it only ran once.  patch retracted.

Thanks,

Nat


Home | Main Index | Thread Index | Old Index