On Thu, 24 Jun 1999 11:06:54 -0700 (PDT) 
 Konrad Schroder <perseant@hhhh.org> wrote:

 > The "mount" family of commands (others too, but I'm not going there now) 
 > has inconsistent and incorrect error reporting, specifically for the case
 > of mount(2) failing.  Many of these commands report this in the form
 > 
 > 	err(1, "%s", "");
 > 
 > which is dead wrong; others use variations which are not so obviously
 > wrong but which leave out the mount point and so IMO don't give out enough
 > information.  I've regularized them in the attached patch, so that they
 > all use (an equivalent of):
 > 
 > 	err(1,"%s on %s", dev, dir);
 > 
 > Note that I want to do this to all of them: they should all report that
 > error the same way, regardless of whether they were "broken" before or
 not.  (It doesn't have to be exactly this format, but they really should
 > all be consistent at least.) 
 > 
 > Please let me know if you have any objections, comments, etc.

I say go ahead and commit these changes.

 > 
 > 						Konrad Schroder
 > 						perseant@hhhh.org
 > 
 > --0-1387222599-930244416=:12056
 > Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="mount_xxx.diff"
 > Content-Transfer-Encoding: BASE64
 > Content-ID: <Pine.NEB.3.96.990624110240.12056Q@hhhh.hitl.washington.edu>
 > Content-Description: 
 > 
 > SW5kZXg6IG1vdW50X2Fkb3MvbW91bnRfYWRvcy5jDQo9PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvYmFzZXNyYy9zYmluL21v
 > dW50X2Fkb3MvbW91bnRfYWRvcy5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24g
 > MS44DQpkaWZmIC11IC1yMS44IG1vdW50X2Fkb3MuYw0KLS0tIG1vdW50X2Fk
 > b3MuYwkxOTk4LzAzLzAxIDAyOjIwOjExCTEuOA0KKysrIG1vdW50X2Fkb3Mu
 > YwkxOTk5LzA2LzI0IDE3OjUwOjIxDQpAQCAtMTM0LDcgKzEzNCw3IEBADQog
 > CX0NCiANCiAJaWYgKG1vdW50KE1PVU5UX0FET1NGUywgZGlyLCBtbnRmbGFn
 > cywgJmFyZ3MpIDwgMCkNCi0JCWVycigxLCAibW91bnQiKTsNCisJCWVycigx
 > LCAiJXMgb24gJXMiLCBkZXYsIGRpcik7DQogDQogCWV4aXQgKDApOw0KIH0N
 > CkluZGV4OiBtb3VudF9jZDk2NjAvbW91bnRfY2Q5NjYwLmMNCj09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9iYXNlc3JjL3Ni
 > aW4vbW91bnRfY2Q5NjYwL21vdW50X2NkOTY2MC5jLHYNCnJldHJpZXZpbmcg
 > cmV2aXNpb24gMS43DQpkaWZmIC11IC1yMS43IG1vdW50X2NkOTY2MC5jDQot
 > LS0gbW91bnRfY2Q5NjYwLmMJMTk5OS8wNS8yOCAxMDoxMDoyNQkxLjcNCisr
 > KyBtb3VudF9jZDk2NjAuYwkxOTk5LzA2LzI0IDE3OjUwOjIyDQpAQCAtMTI0
 > LDcgKzEyNCw3IEBADQogCWFyZ3MuZmxhZ3MgPSBvcHRzOw0KIA0KIAlpZiAo
 > bW91bnQoTU9VTlRfQ0Q5NjYwLCBkaXIsIG1udGZsYWdzLCAmYXJncykgPCAw
 > KQ0KLQkJZXJyKDEsICIlcyIsICIiKTsNCisJCWVycigxLCAiJXMgb24gJXMi
 > LCBkZXYsIGRpcik7DQogCWV4aXQoMCk7DQogfQ0KIA0KSW5kZXg6IG1vdW50
 > X2ZkZXNjL21vdW50X2ZkZXNjLmMNCj09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
 > ClJDUyBmaWxlOiAvY3Zzcm9vdC9iYXNlc3JjL3NiaW4vbW91bnRfZmRlc2Mv
 > bW91bnRfZmRlc2MuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOQ0KZGlm
 > ZiAtdSAtcjEuOSBtb3VudF9mZGVzYy5jDQotLS0gbW91bnRfZmRlc2MuYwkx
 > OTk3LzA5LzE2IDEyOjI2OjU2CTEuOQ0KKysrIG1vdW50X2ZkZXNjLmMJMTk5
 > OS8wNi8yNCAxNzo1MDoyMg0KQEAgLTk0LDcgKzk0LDcgQEANCiAJCXVzYWdl
 > KCk7DQogDQogCWlmIChtb3VudChNT1VOVF9GREVTQywgYXJndlsxXSwgbW50
 > ZmxhZ3MsIE5VTEwpKQ0KLQkJZXJyKDEsICIlcyIsICIiKTsNCisJCWVycigx
 > LCAiZmRlc2Mgb24gJXMiLCBhcmd2WzFdKTsNCiAJZXhpdCgwKTsNCiB9DQog
 > DQpJbmRleDogbW91bnRfZmlsZWNvcmUvbW91bnRfZmlsZWNvcmUuYw0KPT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2Jhc2Vz
 > cmMvc2Jpbi9tb3VudF9maWxlY29yZS9tb3VudF9maWxlY29yZS5jLHYNCnJl
 > dHJpZXZpbmcgcmV2aXNpb24gMS4xDQpkaWZmIC11IC1yMS4xIG1vdW50X2Zp
 > bGVjb3JlLmMNCi0tLSBtb3VudF9maWxlY29yZS5jCTE5OTgvMDgvMTQgMDM6
 > Mzg6NTEJMS4xDQorKysgbW91bnRfZmlsZWNvcmUuYwkxOTk5LzA2LzI0IDE3
 > OjUwOjIzDQpAQCAtMTM4LDcgKzEzOCw3IEBADQogCWFyZ3MuZmxhZ3MgPSBv
 > cHRzOw0KIA0KIAlpZiAobW91bnQoTU9VTlRfRklMRUNPUkUsIGRpciwgbW50
 > ZmxhZ3MsICZhcmdzKSA8IDApDQotCQllcnIoMSwgIiVzIiwgIiIpOw0KKwkJ
 > ZXJyKDEsICIlcyBvbiAlcyIsIGRldiwgZGlyKTsNCiAJZXhpdCgwKTsNCiB9
 > DQogDQpJbmRleDogbW91bnRfa2VybmZzL21vdW50X2tlcm5mcy5jDQo9PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvYmFzZXNy
 > Yy9zYmluL21vdW50X2tlcm5mcy9tb3VudF9rZXJuZnMuYyx2DQpyZXRyaWV2
 > aW5nIHJldmlzaW9uIDEuMTANCmRpZmYgLXUgLXIxLjEwIG1vdW50X2tlcm5m
 > cy5jDQotLS0gbW91bnRfa2VybmZzLmMJMTk5Ny8wOS8xNiAxMjoyOToxNgkx
 > LjEwDQorKysgbW91bnRfa2VybmZzLmMJMTk5OS8wNi8yNCAxNzo1MDoyMw0K
 > QEAgLTk0LDcgKzk0LDcgQEANCiAJCXVzYWdlKCk7DQogDQogCWlmIChtb3Vu
 > dChNT1VOVF9LRVJORlMsIGFyZ3ZbMV0sIG1udGZsYWdzLCBOVUxMKSkNCi0J
 > CWVycigxLCAiJXMiLCAiIik7DQorCQllcnIoMSwgImtlcm5mcyBvbiAlcyIs
 > IGFyZ3ZbMV0pOw0KIAlleGl0KDApOw0KIH0NCiANCkluZGV4OiBtb3VudF9s
 > ZnMvbW91bnRfbGZzLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBm
 > aWxlOiAvY3Zzcm9vdC9iYXNlc3JjL3NiaW4vbW91bnRfbGZzL21vdW50X2xm
 > cy5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS43DQpkaWZmIC11IC1yMS43
 > IG1vdW50X2xmcy5jDQotLS0gbW91bnRfbGZzLmMJMTk5OC8wMy8wMSAwMjoy
 > MDo0MQkxLjcNCisrKyBtb3VudF9sZnMuYwkxOTk5LzA2LzI0IDE3OjUwOjI0
 > DQpAQCAtNTMsNiArNTMsNyBAQA0KICNpbmNsdWRlIDx1ZnMvdWZzL3Vmc21v
 > dW50Lmg+DQogDQogI2luY2x1ZGUgPGVyci5oPg0KKyNpbmNsdWRlIDxlcnJu
 > by5oPg0KICNpbmNsdWRlIDxzdGRpby5oPg0KICNpbmNsdWRlIDxzdGRsaWIu
 > aD4NCiAjaW5jbHVkZSA8c3RyaW5nLmg+DQpAQCAtODEsNiArODIsNyBAQA0K
 > IAlzdHJ1Y3QgdWZzX2FyZ3MgYXJnczsNCiAJaW50IGNoLCBtbnRmbGFncywg
 > bm9jbGVhbjsNCiAJY2hhciAqZnNfbmFtZSwgKm9wdGlvbnM7DQorCWNvbnN0
 > IGNoYXIgKmVycmNhdXNlOw0KIA0KIAlvcHRpb25zID0gTlVMTDsNCiAJbW50
 > ZmxhZ3MgPSBub2NsZWFuID0gMDsNCkBAIC0xMDgsNyArMTEwLDcgQEANCiAJ
 > aWYgKGFyZ2MgIT0gMikNCiAJCXVzYWdlKCk7DQogDQotICAgICAgICBhcmdz
 > LmZzcGVjID0gYXJndlswXTsJLyogdGhlIG5hbWUgb2YgdGhlIGRldmljZSBm
 > aWxlICovDQorCWFyZ3MuZnNwZWMgPSBhcmd2WzBdOwkvKiB0aGUgbmFtZSBv
 > ZiB0aGUgZGV2aWNlIGZpbGUgKi8NCiAJZnNfbmFtZSA9IGFyZ3ZbMV07CS8q
 > IHRoZSBtb3VudCBwb2ludCAqLw0KIA0KICNkZWZpbmUgREVGQVVMVF9ST09U
 > VUlECS0yDQpAQCAtMTE4LDggKzEyMCwyNCBAQA0KIAllbHNlDQogCQlhcmdz
 > LmV4cG9ydC5leF9mbGFncyA9IDA7DQogDQotCWlmIChtb3VudChNT1VOVF9M
 > RlMsIGZzX25hbWUsIG1udGZsYWdzLCAmYXJncykpDQotCQllcnIoMSwgIiVz
 > IiwgIiIpOw0KKwlpZiAobW91bnQoTU9VTlRfTEZTLCBmc19uYW1lLCBtbnRm
 > bGFncywgJmFyZ3MpKSB7DQorCQlzd2l0Y2ggKGVycm5vKSB7DQorCQljYXNl
 > IEVNRklMRToNCisJCQllcnJjYXVzZSA9ICJtb3VudCB0YWJsZSBmdWxsIjsN
 > CisJCQlicmVhazsNCisJCWNhc2UgRUlOVkFMOg0KKwkJCWlmIChtbnRmbGFn
 > cyAmIE1OVF9VUERBVEUpDQorCQkJCWVycmNhdXNlID0NCisJCQkgICAgInNw
 > ZWNpZmllZCBkZXZpY2UgZG9lcyBub3QgbWF0Y2ggbW91bnRlZCBkZXZpY2Ui
 > Ow0KKwkJCWVsc2UNCisJCQkJZXJyY2F1c2UgPSAiaW5jb3JyZWN0IHN1cGVy
 > IGJsb2NrIjsNCisJCQlicmVhazsNCisJCWRlZmF1bHQ6DQorCQkJZXJyY2F1
 > c2UgPSBzdHJlcnJvcihlcnJubyk7DQorCQkJYnJlYWs7DQorCQl9DQorCQll
 > cnJ4KDEsICIlcyBvbiAlczogJXMiLCBhcmdzLmZzcGVjLCBmc19uYW1lLCBl
 > cnJjYXVzZSk7DQorCX0NCiANCiAJaWYgKCFub2NsZWFuKQ0KIAkJaW52b2tl
 > X2NsZWFuZXIoZnNfbmFtZSk7DQpJbmRleDogbW91bnRfbXNkb3MvbW91bnRf
 > bXNkb3MuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9j
 > dnNyb290L2Jhc2VzcmMvc2Jpbi9tb3VudF9tc2Rvcy9tb3VudF9tc2Rvcy5j
 > LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOQ0KZGlmZiAtdSAtcjEuMTkg
 > bW91bnRfbXNkb3MuYw0KLS0tIG1vdW50X21zZG9zLmMJMTk5OC8wMy8wMSAw
 > MjoyMDo0NQkxLjE5DQorKysgbW91bnRfbXNkb3MuYwkxOTk5LzA2LzI0IDE3
 > OjUwOjI0DQpAQCAtMTQ2LDcgKzE0Niw3IEBADQogCX0NCiANCiAJaWYgKG1v
 > dW50KE1PVU5UX01TRE9TLCBkaXIsIG1udGZsYWdzLCAmYXJncykgPCAwKQ0K
 > LQkJZXJyKDEsICJtb3VudCIpOw0KKwkJZXJyKDEsICIlcyBvbiAlcyIsIGRl
 > diwgZGlyKTsNCiANCiAJZXhpdCAoMCk7DQogfQ0KSW5kZXg6IG1vdW50X251
 > bGwvbW91bnRfbnVsbC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
 > ZmlsZTogL2N2c3Jvb3QvYmFzZXNyYy9zYmluL21vdW50X251bGwvbW91bnRf
 > bnVsbC5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS41DQpkaWZmIC11IC1y
 > MS41IG1vdW50X251bGwuYw0KLS0tIG1vdW50X251bGwuYwkxOTk3LzA5LzE2
 > IDEyOjMxOjAyCTEuNQ0KKysrIG1vdW50X251bGwuYwkxOTk5LzA2LzI0IDE3
 > OjUwOjI2DQpAQCAtMTA2LDcgKzEwNiw3IEBADQogCWFyZ3MudGFyZ2V0ID0g
 > dGFyZ2V0Ow0KIA0KIAlpZiAobW91bnQoTU9VTlRfTlVMTCwgYXJndlsxXSwg
 > bW50ZmxhZ3MsICZhcmdzKSkNCi0JCWVycigxLCAiJXMiLCAiIik7DQorCQll
 > cnIoMSwgIiVzIG9uICVzIiwgdGFyZ2V0LCBhcmd2WzFdKTsNCiAJZXhpdCgw
 > KTsNCiB9DQogDQpJbmRleDogbW91bnRfcHJvY2ZzL21vdW50X3Byb2Nmcy5j
 > DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3Qv
 > YmFzZXNyYy9zYmluL21vdW50X3Byb2Nmcy9tb3VudF9wcm9jZnMuYyx2DQpy
 > ZXRyaWV2aW5nIHJldmlzaW9uIDEuOQ0KZGlmZiAtdSAtcjEuOSBtb3VudF9w
 > cm9jZnMuYw0KLS0tIG1vdW50X3Byb2Nmcy5jCTE5OTcvMDkvMTYgMTI6MzI6
 > MDQJMS45DQorKysgbW91bnRfcHJvY2ZzLmMJMTk5OS8wNi8yNCAxNzo1MDoy
 > Ng0KQEAgLTk0LDcgKzk0LDcgQEANCiAJCXVzYWdlKCk7DQogDQogCWlmICht
 > b3VudChNT1VOVF9QUk9DRlMsIGFyZ3ZbMV0sIG1udGZsYWdzLCBOVUxMKSkN
 > Ci0JCWVycigxLCAiJXMiLCAiIik7DQorCQllcnIoMSwgInByb2NmcyBvbiAl
 > cyIsIGFyZ3ZbMV0pOw0KIAlleGl0KDApOw0KIH0NCiANCkluZGV4OiBtb3Vu
 > dF91bWFwL21vdW50X3VtYXAuYw0KPT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
 > UkNTIGZpbGU6IC9jdnNyb290L2Jhc2VzcmMvc2Jpbi9tb3VudF91bWFwL21v
 > dW50X3VtYXAuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOA0KZGlmZiAt
 > dSAtcjEuOCBtb3VudF91bWFwLmMNCi0tLSBtb3VudF91bWFwLmMJMTk5OS8w
 > Ni8wMSAxOToxNjo0OQkxLjgNCisrKyBtb3VudF91bWFwLmMJMTk5OS8wNi8y
 > NCAxNzo1MDozMQ0KQEAgLTIzMCw3ICsyMzAsNyBAQA0KIAlhcmdzLmdtYXBk
 > YXRhID0gZ21hcGRhdGE7DQogDQogCWlmIChtb3VudChNT1VOVF9VTUFQLCBh
 > cmd2WzFdLCBtbnRmbGFncywgJmFyZ3MpKQ0KLQkJZXJyKDEsICIlcyIsICIi
 > KTsNCisJCWVycigxLCAiJXMgb24gJXMiLCBzb3VyY2UsIGFyZ3ZbMV0pOw0K
 > IAlleGl0KDApOw0KIH0NCiANCkluZGV4OiBtb3VudF91bmlvbi9tb3VudF91
 > bmlvbi5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 > PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2
 > c3Jvb3QvYmFzZXNyYy9zYmluL21vdW50X3VuaW9uL21vdW50X3VuaW9uLmMs
 > dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjUNCmRpZmYgLXUgLXIxLjUgbW91
 > bnRfdW5pb24uYw0KLS0tIG1vdW50X3VuaW9uLmMJMTk5Ny8wOS8xNiAxMjoz
 > Mjo1NAkxLjUNCisrKyBtb3VudF91bmlvbi5jCTE5OTkvMDYvMjQgMTc6NTA6
 > MzENCkBAIC0xMTcsNyArMTE3LDcgQEANCiAJYXJncy50YXJnZXQgPSB0YXJn
 > ZXQ7DQogDQogCWlmIChtb3VudChNT1VOVF9VTklPTiwgYXJndlsxXSwgbW50
 > ZmxhZ3MsICZhcmdzKSkNCi0JCWVycigxLCAiJXMiLCAiIik7DQorCQllcnIo
 > MSwgIiVzIG9uICVzIiwgdGFyZ2V0LCBhcmd2WzFdKTsNCiAJZXhpdCgwKTsN
 > CiB9DQogDQo=
 > --0-1387222599-930244416=:12056--

        -- Jason R. Thorpe <thorpej@nas.nasa.gov>