Subject: Use of BINOWN?= or BINGRP?= in Makefiles.inc?
To: None <tech-userlevel@netbsd.org>
From: Bernd Ernesti <netbsd@arresum.inka.de>
List: tech-userlevel
Date: 06/11/2000 22:47:50
Hi,

I have the following problem with postfix:

#  postfix check
postfix-script: warning: not owned by root: /usr/libexec/postfix/bounce
postfix-script: warning: not owned by root: /usr/libexec/postfix/cleanup
postfix-script: warning: not owned by root: /usr/libexec/postfix/error
postfix-script: warning: not owned by root: /usr/libexec/postfix/local
postfix-script: warning: not owned by root: /usr/libexec/postfix/master
postfix-script: warning: not owned by root: /usr/libexec/postfix/pickup
postfix-script: warning: not owned by root: /usr/libexec/postfix/pipe
postfix-script: warning: not owned by root: /usr/libexec/postfix/qmgr
postfix-script: warning: not owned by root: /usr/libexec/postfix/sendmail
postfix-script: warning: not owned by root: /usr/libexec/postfix/showq
postfix-script: warning: not owned by root: /usr/libexec/postfix/smtp
postfix-script: warning: not owned by root: /usr/libexec/postfix/smtpd
postfix-script: warning: not owned by root: /usr/libexec/postfix/trivial-rewrite
postfix-script: warning: not owned by root: /etc/postfix/README
postfix-script: warning: not owned by root: /etc/postfix/main.cf
postfix-script: warning: not owned by root: /etc/postfix/master.cf
postfix-script: warning: not owned by root: /etc/postfix/postfix-script

That happens because I set BINOWN?= and BINGRP?= /etc/mk.conf
so these programms are not owned by root.

I thought about to change the Makefiles in gnu/usr.sbin/postfix/*/ but
Perry hat the idea to just change gnu/usr.sbin/postfix/Makefile.inc.
The following patch has a problem in postdrop/Makefile:

Index: Makefile.inc
===================================================================
RCS file: /cvsroot/gnusrc/gnu/usr.sbin/postfix/Makefile.inc,v
retrieving revision 1.1
diff -c -r1.1 Makefile.inc
*** Makefile.inc	2000/04/30 21:21:51	1.1
--- Makefile.inc	2000/06/11 20:40:07
***************
*** 31,36 ****
--- 31,39 ----
  PFIX_EXAMPLEDIR=/usr/share/examples/postfix
  PFIX_SBINDIR=	/usr/sbin
  
+ BINOWN=	root
+ BINGRP=	wheel
+ 
  .if exists(${.CURDIR}/../../Makefile.inc)
  .include "${.CURDIR}/../../Makefile.inc"
  .endif

postdrop needs to be setgid maildrop and the BINGRP in the Makefile.inc overwrites
that :(

Now, I could fix the problem when I use BINOWN?= and BINGRP?= in the Makefile.inc:

Index: Makefile.inc
===================================================================
RCS file: /cvsroot/gnusrc/gnu/usr.sbin/postfix/Makefile.inc,v
retrieving revision 1.1
diff -c -r1.1 Makefile.inc
*** Makefile.inc	2000/04/30 21:21:51	1.1
--- Makefile.inc	2000/06/11 20:40:07
***************
*** 31,36 ****
--- 31,39 ----
  PFIX_EXAMPLEDIR=/usr/share/examples/postfix
  PFIX_SBINDIR=	/usr/sbin
  
+ BINOWN?=	root
+ BINGRP?=	wheel
+ 
  .if exists(${.CURDIR}/../../Makefile.inc)
  .include "${.CURDIR}/../../Makefile.inc"
  .endif

Is it okay to use that or do I need to change the 14 Makefiles?

Bernd