Subject: Re: CVS commit: basesrc
To: Martin J. Laubach <mjl@netbsd.org>
From: Jason R Thorpe <thorpej@zembu.com>
List: tech-userlevel
Date: 03/11/2001 16:33:04
On Sun, Mar 11, 2001 at 03:57:45PM +0200, Martin J. Laubach wrote:

 > Module Name:	basesrc
 > Committed By:	mjl
 > Date:		Sun Mar 11 13:57:45 UTC 2001
 > 
 > Modified Files:
 > 	basesrc/distrib/sets/lists/base: shl.mi
 > 	basesrc/lib/libskey: shlib_version skeysubr.c
 > 
 > Log Message:
 > Fix incorrect SHA1 calculation on big endian machines reported
 > in PR/12045 by John Valdes, who also provided the problem's
 > solution and a patch.

There was no API/ABI change in this -- it was wrong to bump the shlib
minor from 0 -> 1.  Please revert the shlib version portion immediately.

Also, the "fix" is pretty disgusting -- it mucks around with what is
essentially an internal datastructure of the SHA1 implementation.

-- 
        -- Jason R. Thorpe <thorpej@zembu.com>