--Multipart_Fri_Jan_24_23:37:15_2003-1
Content-Type: text/plain; charset=US-ASCII

Hi

At Mon, 20 Jan 2003 00:52:05 -0800,
Jason R Thorpe wrote:
> Ah, I see I made a mistake in the Xthreads.h part of the patch.  I'll
> correct it and post again.

thr_key_{create,delete} -> thr_key{create,delete}?
       ^
(or, are you planning to change stub name in libc?)

>  > ico.o(.text+0x2064): undefined reference to `pthread_cond_init'
>  > ico.o(.text+0x209d): undefined reference to `pthread_create'
>  > ico.o(.text+0x20b3): undefined reference to `pthread_mutex_lock'
>  > ico.o(.text+0x20c5): undefined reference to `pthread_cond_wait'
>  > ico.o(.text+0x20d5): undefined reference to `pthread_mutex_unlock'
>  > *** Error code 1 (continuing)
> 
> ...though, I am a bit puzzled as to what is creating the direct pthread
> references in this case...

I enabled `# define ThreadsLibraries	-lpthread' line again, then xsrc
build was completed without any problem.

% grep pthread XSRCBUILDLOG
gcc -o makekeys -O2  -ansi -Dasm=__asm    -I../.. -I../../exports/include   -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO -DXTHREADS  -D_REENTRANT -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI  -DUSE_NBSD_THREADLIB    -DHAS_SNPRINTF -DLIBX11   util/makekeys.c -L/usr/X11R6/lib -lpthread   -Wl,-rpath,/usr/X11R6/lib -Wl,-rpath-link,../../exports/lib
+ gcc -o ./libGL.so.1.2~ -shared -Wl,-rpath,/usr/X11R6/lib -Wl,-soname,libGL.so.1 ../../../lib/GL/glx/clientattrib.o ../../../lib/GL/glx/compsize.o ../../../lib/GL/glx/dispatch.o ../../../lib/GL/glx/eval.o ../../../lib/GL/glx/g_render.o ../../../lib/GL/glx/g_single.o ../../../lib/GL/glx/g_vendpriv.o ../../../lib/GL/glx/glapi.o ../../../lib/GL/glx/glapinoop.o ../../../lib/GL/glx/glthread.o ../../../lib/GL/glx/glxcmds.o ../../../lib/GL/glx/glxext.o ../../../lib/GL/glx/indirect_init.o ../../../lib/GL/glx/pixel.o ../../../lib/GL/glx/pixelstore.o ../../../lib/GL/glx/render2.o ../../../lib/GL/glx/renderpix.o ../../../lib/GL/glx/single2.o ../../../lib/GL/glx/singlepix.o ../../../lib/GL/glx/vertarr.o ../../../lib/GL/glx/xfont.o -lpthread
gcc -o ico -O2 -ansi -Dasm=__asm     -L../../exports/lib ico.o -lXext -lX11 -L/usr/X11R6/lib -lpthread -lm   -Wl,-rpath,/usr/X11R6/lib -Wl,-rpath-link,../../exports/lib
gcc -o glxinfo -O2 -ansi -Dasm=__asm     -L../../exports/lib glxinfo.o -lGLU -lGL -lXext -lX11 -L/usr/X11R6/lib -lpthread -lm   -Wl,-rpath,/usr/X11R6/lib -Wl,-rpath-link,../../exports/lib
gcc -o glxgears -O2 -ansi -Dasm=__asm     -L../../exports/lib glxgears.o -lGL -lXext -lX11 -L/usr/X11R6/lib -lpthread -lm   -Wl,-rpath,/usr/X11R6/lib -Wl,-rpath-link,../../exports/lib

It seems that only these programs are linked to libpthread...

Is this correct?

--
FUKAUMI Naoki

--Multipart_Fri_Jan_24_23:37:15_2003-1
Content-Type: application/octet-stream
Content-Disposition: attachment; filename="xthreads-patch2"
Content-Transfer-Encoding: base64

SW5kZXg6IHhmcmVlL3hjL2NvbmZpZy9jZi9OZXRCU0QuY2YKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog
L2N2c3Jvb3QveHNyYy94ZnJlZS94Yy9jb25maWcvY2YvTmV0QlNELmNmLHYKcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjM4CmRpZmYgLXUgLXIxLjM4IE5ldEJTRC5jZgotLS0geGZyZWUveGMvY29uZmln
L2NmL05ldEJTRC5jZgkyMDAzLzAxLzE5IDE0OjM3OjE5CTEuMzgKKysrIHhmcmVlL3hjL2NvbmZp
Zy9jZi9OZXRCU0QuY2YJMjAwMy8wMS8yNCAxMzo1ODozMApAQCAtOTksNiArOTksNyBAQAogICog
TmV0QlNEIDEuNk0gYW5kIG5ld2VyIHN1cHBvcnRzIFBPU0lYIFRocmVhZHMuCiAgKi8KIAorI2Rl
ZmluZQlOZXRCU0RUaHJlYWRzCiAjaWYgZGVmaW5lZChOZXRCU0RUaHJlYWRzKSAmJiBcCiAgICAg
KChPU01ham9yVmVyc2lvbiA+IDEpIHx8IFwKICAgICAgKE9TTWFqb3JWZXJzaW9uID09IDEgJiYg
T1NNaW5vclZlcnNpb24gPiA2KSB8fCBcCkBAIC0xMDgsOSArMTA5LDEwIEBACiAjIGRlZmluZSBU
aHJlYWRlZFgJCVlFUwogIyBkZWZpbmUgSGFzVGhyZWFkU2FmZUFQSQlZRVMKICMgZGVmaW5lIFRo
cmVhZHNMaWJyYXJpZXMJLWxwdGhyZWFkCisjIGRlZmluZSBMaWJyYXJ5TVREZWZpbmVzCS1EVVNF
X05CU0RfVEhSRUFETElCCiAjIGRlZmluZSBTeXN0ZW1NVERlZmluZXMJLURfUkVFTlRSQU5UCiAj
IGRlZmluZSBNVFNhZmVBUElEZWZpbmVzCS1EWFVTRV9NVFNBRkVfQVBJIC1EWE5PX01UU0FGRV9Q
V0RBUEkKLSMgZGVmaW5lIFNoYXJlZFgxMVJlcXMJCS1scHRocmVhZAorWENPTU0gIyBkZWZpbmUg
U2hhcmVkWDExUmVxcwkJLWxwdGhyZWFkCiAjZW5kaWYKIAogLyoKSW5kZXg6IHhmcmVlL3hjL2lu
Y2x1ZGUvWHRocmVhZHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC94c3JjL3hmcmVl
L3hjL2luY2x1ZGUvWHRocmVhZHMuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xLjEuNApkaWZm
IC11IC1yMS4xLjEuNCBYdGhyZWFkcy5oCi0tLSB4ZnJlZS94Yy9pbmNsdWRlL1h0aHJlYWRzLmgJ
MjAwMi8wMS8xOSAxNDo1OToyNQkxLjEuMS40CisrKyB4ZnJlZS94Yy9pbmNsdWRlL1h0aHJlYWRz
LmgJMjAwMy8wMS8yNCAxMzo1ODozMwpAQCAtMTk2LDYgKzE5NiwzNyBAQAogI2RlZmluZSB4Y29u
ZGl0aW9uX3NpZ25hbChjKSB0aXNfY29uZF9zaWduYWwoYykKICNkZWZpbmUgeGNvbmRpdGlvbl9i
cm9hZGNhc3QoYykgdGlzX2NvbmRfYnJvYWRjYXN0KGMpCiAjZWxzZQorI2lmZGVmIFVTRV9OQlNE
X1RIUkVBRExJQgorLyoKKyAqIE5ldEJTRCB0aHJlYWRsaWIgc3VwcG9ydCBpcyBpbnRlbmRlZCBm
b3IgdGhyZWFkIHNhZmUgbGlicmFyaWVzLgorICogVGhpcyBzaG91bGQgbm90IGJlIHVzZWQgZm9y
IGdlbmVyYWwgY2xpZW50IHByb2dyYW1taW5nLgorICovCisjaW5jbHVkZSA8dGhyZWFkbGliLmg+
Cit0eXBlZGVmIHRocl90IHh0aHJlYWRfdDsKK3R5cGVkZWYgdGhyZWFkX2tleV90IHh0aHJlYWRf
a2V5X3Q7Cit0eXBlZGVmIGNvbmRfdCB4Y29uZGl0aW9uX3JlYzsKK3R5cGVkZWYgbXV0ZXhfdCB4
bXV0ZXhfcmVjOworI2RlZmluZSB4dGhyZWFkX3NlbGYgdGhyX3NlbGYKKyNkZWZpbmUgeHRocmVh
ZF9mb3JrKGZ1bmMsY2xvc3VyZSkgeyB0aHJfdCBfdG1weHRocjsgXAorCS8qIFhYWCBDcmVhdGUg
aXQgZGV0YWNoZWQ/ICAtLXRob3JwZWogKi8gXAorCXRocl9jcmVhdGUoJl90bXB4dGhyLE5VTEws
ZnVuYyxjbG9zdXJlKTsgfQorI2RlZmluZSB4dGhyZWFkX3lpZWxkKCkgdGhyX3lpZWxkKCkKKyNk
ZWZpbmUgeHRocmVhZF9leGl0KHYpIHRocl9leGl0KHYpCisjZGVmaW5lIHh0aHJlYWRfa2V5X2Ny
ZWF0ZShrcCxkKSB0aHJfa2V5Y3JlYXRlKGtwLGQpCisjZGVmaW5lIHh0aHJlYWRfa2V5X2RlbGV0
ZShrKSB0aHJfa2V5ZGVsZXRlKGspCisjZGVmaW5lIHh0aHJlYWRfc2V0X3NwZWNpZmljKGssdikg
dGhyX3NldHNwZWNpZmljKGssdikKKyNkZWZpbmUgeHRocmVhZF9nZXRfc3BlY2lmaWMoayx2cCkg
Kih2cCkgPSB0aHJfZ2V0c3BlY2lmaWMoaykKKyNkZWZpbmUgWE1VVEVYX0lOSVRJQUxJWkVSIE1V
VEVYX0lOSVRJQUxJWkVSCisjZGVmaW5lIHhtdXRleF9pbml0KG0pIG11dGV4X2luaXQobSwgMCkK
KyNkZWZpbmUgeG11dGV4X2NsZWFyKG0pIG11dGV4X2Rlc3Ryb3kobSkKKyNkZWZpbmUgeG11dGV4
X2xvY2sobSkgbXV0ZXhfbG9jayhtKQorI2RlZmluZSB4bXV0ZXhfdW5sb2NrKG0pIG11dGV4X3Vu
bG9jayhtKQorI2RlZmluZSB4Y29uZGl0aW9uX2luaXQoYykgY29uZF9pbml0KGMsIDAsIDApCisj
ZGVmaW5lIHhjb25kaXRpb25fY2xlYXIoYykgY29uZF9kZXN0cm95KGMpCisjZGVmaW5lIHhjb25k
aXRpb25fd2FpdChjLG0pIGNvbmRfd2FpdChjLG0pCisjZGVmaW5lIHhjb25kaXRpb25fc2lnbmFs
KGMpIGNvbmRfc2lnbmFsKGMpCisjZGVmaW5lIHhjb25kaXRpb25fYnJvYWRjYXN0KGMpIGNvbmRf
YnJvYWRjYXN0KGMpCisjZWxzZQogI2luY2x1ZGUgPHB0aHJlYWQuaD4KIHR5cGVkZWYgcHRocmVh
ZF90IHh0aHJlYWRfdDsKIHR5cGVkZWYgcHRocmVhZF9rZXlfdCB4dGhyZWFkX2tleV90OwpAQCAt
MjQ4LDYgKzI3OSw3IEBACiAjZGVmaW5lIHhjb25kaXRpb25fc2V0X25hbWUoY3Ysc3RyKSAoKGNo
YXIqKikoY3YpLT5maWVsZDEpWzVdID0gKHN0cikKICNlbmRpZiAvKiBERUJVRyAqLwogI2VuZGlm
IC8qIF9DTUFfVkVORE9SXyA9PSBfQ01BX19JQk0gKi8KKyNlbmRpZiAvKiBVU0VfTkJTRF9USFJF
QURMSUIgKi8KICNlbmRpZiAvKiBVU0VfVElTX1NVUFBPUlQgKi8KICNlbmRpZiAvKiBXSU4zMiAq
LwogI2VuZGlmIC8qIFNWUjQgKi8K

--Multipart_Fri_Jan_24_23:37:15_2003-1--