--SWTRyWv/ijrBap1m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 27, 2003 at 11:23:55PM -0500, der Mouse wrote:
> Is it just me, or is make's archive handling rather borked?

I don't think I've ever used make's archive handling, so I'm not sure. :-)

> % cat z
> foo.a(bar.o): bar.o
> 	ar rv foo.a bar.o
> % make -n -f z
> "z", line 1: Missing dependency operator
>=20
> The exact wording of the message, and whether more messages follow,
> varies with which make rev you use; I noticed it in my old (1.4T) make,
> it appears to be present in 1.6.1 as well, and diffing source makes me
> suspect it's in -current.  (The problem appears to be that cp is left
> pointing nowhere useful after Arch_ParseArchive(), but it's used to
> check the dependency operator character anyway.)
>=20
> Adding a "cp =3D line;" in the success case (before line 1007, as of
> usr.bin/make/parse.c 1.94) looks right, and appears to fix it in a
> smoke-test I just did in my 1.4T make.
>=20
> Worth sending-PR?

Probably. Sounds like a simple under-initialized variable problem. :-)

Take care,

Bill

--SWTRyWv/ijrBap1m
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQE/yDRVWz+3JHUci9cRArhXAJ405uUSUs6fbqWCYA1do4fp5ZgDUACfXmKo
2SzAnClXqsGdY+XjDuN9yFY=
=Edkj
-----END PGP SIGNATURE-----

--SWTRyWv/ijrBap1m--