--OROCMA9jn6tkzFBc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 26, 2005 at 02:33:52PM +0000, Charles M. Hannum wrote:
> On Monday 26 September 2005 05:45, Chuck Silvers wrote:
> > Module Name:	src
> > Committed By:	chs
> > Date:		Mon Sep 26 05:45:13 UTC 2005
> >
> > Modified Files:
> > 	src/libexec/ld.elf_so/arch/powerpc: ppc_reloc.c
> >
> > Log Message:
> > fix two problems with icache invalidation of the PLT:
> >  - restore revision 1.33, it was correct.
>=20
> It took me a few minutes to refresh myself on what's going on here, but...
>=20
> No, it is *not* correct.  Please take the time to understand the PLT form=
at=20
> before messing with it.
>=20
> On PPC, the PLT area is split into two sections: the first contains code,=
 and=20
> is actually 8 or 16 bytes per entry; the second contains pointers, and do=
es=20
> not need to be synced.  The 8 vs. 16 split happens if the PLT is larger t=
han=20
> 8192 entries.
>=20
> I have to admit that I'm not completely sure if the "large PLT" support d=
oes=20
> the right arithmetic -- I never got clear documentation on the format -- =
but=20
> the basic deal of only flushing 8 (or 16) bytes is definitely correct, an=
d=20
> should not have been changed.
>=20
> Please revert it and add a comment for the next person who is going to sc=
rew=20
> it up.  I believe Matt Thomas is the one who clued me into this the first=
=20
> time around.

Then I think we are left with a problem. A previous thread on=20
tech-userlevel indicated that this change (well, the patch Chuck sent out=
=20
which led to this change) fixed build issues for at least one user. So if=
=20
this fix is not right, then we have a problem that it masks. :-|

Take care,

Bill

--OROCMA9jn6tkzFBc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFDPFz7Wz+3JHUci9cRAtXWAJ45LpXQl9F+oC/RmkANJa33pHqyUwCfX2JM
0/5sW4z39yOGtMS75SmLjVk=
=hDQu
-----END PGP SIGNATURE-----

--OROCMA9jn6tkzFBc--