Subject: Re: make use sigaction instead of signal
To: Jeremy C. Reed <reed@reedmedia.net>
From: David Laight <david@l8s.co.uk>
List: tech-userlevel
Date: 10/04/2006 22:05:48
On Wed, Oct 04, 2006 at 04:00:58PM -0500, Jeremy C. Reed wrote:
> Our bmake has been reported to not exit sub makes with CTRL-C on Darwin,
> DragonFly and Linux. See PR pkg/31013.
>
> Matt Dillon of DragonFly fixed their usr.bin/make today for this.
>
> Their code now uses sigaction instead of signal to fix this.
>
> But I see our code and DragonFly and FreeBSD and OpenBSD have diverged on
> this. DragonFly and FreeBSD have merged compat.c into job.c. DragonFly and
> OpenBSD have a signal counter.
>
> The fix for just SIGINT should be easy, but maybe it would be better to
> try to keep all these in sync better -- which is a bigger job.
Given the changes I've made recently in order to get parallel makes to
stop in a finite time when an error happens on one branch, I suspect
that a merge in either direction will be painful.
The signal handling of different Unix systems does vary somewhat....
David
--
David Laight: david@l8s.co.uk