tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: patch update



In article <20080829155818.GB13113%apb-laptoy.apb.alt.za@localhost>,
Alan Barrett  <apb%cequrux.com@localhost> wrote:
>On Fri, 29 Aug 2008, Joerg Sonnenberger wrote:
>> On Fri, Aug 29, 2008 at 11:08:43AM +0200, Alan Barrett wrote:
>> > New behaviour: You can change whether or not a ".orig" file gets
>> > created, but you can't change its name.  ".orig" files are not created
>> > by default, and "-b" (no argument) can be used to create a ".orig" file.
>> 
>> --suffix can be used for both old and new patch version to get the
>> result of old -b. For new patch -z can be used.
>
>Oh, I see.  I am not sure that introducing a new -z option (which is not
>in SUSv3) is the right thing.  Why not just leave --suffix as a long
>option that does not have a corresponding short option?  I see that GNU
>patch also uses "-z" in this way, so I don't object to it, even though
>it's not clear to me that it's the right thing to do.
>
>Summary: Importing the proposed new patch(1) seems fine to me.

Yes please import it; our patch is too crufty to be maintainable.

christos



Home | Main Index | Thread Index | Old Index