Re: wedge like devices and newfs

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Jun 02, 2009 at 12:25:30PM +0200, Adam Hamsik wrote:
>
> On Jun,Tuesday 2 2009, at 11:53 AM, Manuel Bouyer wrote:
>
>> On Fri, May 29, 2009 at 07:39:33PM +0200, Adam Hamsik wrote:
>>>> If DIOCGDINFO fails, newfs (and other tools using getdiskinfo())  
>>>> will
>>>> use
>>>> DIOCGWEDGEINFO.  Maybe having zvols should handle DIOCGWEDGEINFO ?
>>> Yes but DIOCGWEDGEINFO is used only to get name of parent device on
>>> which
>>> DIOCGDINFO is later called. Everything which was received from  
>>> WEDGEINFO
>>> ioctl
>>> was later zeroed and replaced by information from CGDINFO call.
>>
>> No, if WEDGEINFO was used, part2wedge is not called and informations  
>> from
>> WEDGEINFO is not erased.
>
> Ah I see, sorry. Problem is that e.g. for newfs information in  
> wedge_info are not enough. For working newfs you need DIOCGDINFO because 
> otherwise it will not know sector size. And we are back to main proble 
> that I need to implement disklabels for devices where disklabel doesn't 
> make any sense. I still thing that my patch simplifies this code a lot, 
> add support for wedge like devices and still support old disk devices.

Yes, now I understand why you want to change this.

-- 
Manuel Bouyer, LIP6, Universite Paris VI.           
Manuel.Bouyer%lip6.fr@localhost
     NetBSD: 26 ans d'experience feront toujours la difference
--