Re: [PATCH] pcictl: simplify its usage

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Jun 04, 2009 at 12:37:30PM +0200, Christoph Egger wrote:
> > I meant, a command to pcictl (like list and dump, something like listbus)
> 
> It wouldn't work that way.
> The functionality provided by pcictl is limited by the device file.
> For example, /dev/pci3 only lets it operate with devices attached on pci3.
> I need pcictl to operate on *all* devices therefore I had to fold the pci
> device files into one. This is the main functional change from the kernel 
> side.

You could have a /dev/pci node which lets you operate on all busses, and/or
get the list of busses, and the /dev/pci[0-9] nodes for backward
compatibility.

I didn't notice there were kernel changes. You need to keep the /dev/pci[0-9]
nodes for backward compatibility anyway.

And you also need to patch Xorg and Xfree which also use the /dev/pci[0-9]
interface. There is probably other programs in pkgsrc which do the same.

> > >
> > > Compile it with COMPAT50 #defined and it understands the old syntax as
> > > well.
> >
> > Do you intend to have COMPAT50 defined by default ?
> 
> This is a good point to turn into a survey.
> I will do what people agree with.
> If the answer is yes, should I define COMPAT50 in the pcictl.c source or in 
> the Makefile ?

I don't think a compile-time option is a good way to handle this.

-- 
Manuel Bouyer, LIP6, Universite Paris VI.           
Manuel.Bouyer%lip6.fr@localhost
     NetBSD: 26 ans d'experience feront toujours la difference
--