Re: [PATCH] pcictl: simplify its usage

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On Thursday 04 June 2009 17:49:48 Manuel Bouyer wrote:
> On Thu, Jun 04, 2009 at 04:41:50PM +0200, Magnus Eriksson wrote:
> > On Thu, 4 Jun 2009, Manuel Bouyer wrote:
> >>> With my patch I get this with a simple
> >>>
> >>>     PCIDEVS=`pcictl list`
> >>
> >> But it breaks backward compat, this could easily be fixed by using a
> >> command line flag for the new behavior.
> >
> > I'm "just a user", but I don't see why you would have to break
> > compatibility at all.  Is there some ambiguity I can't see that would
> > rear its head if the syntax was just expanded to include both "new" and
> > "old" styles?
> >
> > (As far as I can see, the pcibus argument has to come before any command
> > or options, so you could just fall through to newstyle if it's not
> > found.)
> >
> > i.e:
> >
> > pcictl pci0 list  -> old: list all on pci0
> >
> > pcictl [BLANK] list  -> new: list all on all
> >
> > pcictl [BLANK] list -b 1  -> new: list all on pci1
>
> Yes, this would work too.

Manuel: In case you haven't realized it yet, this is what the patch does.
If you compile pcictl with COMPAT50, pcictl understands both the old
and new syntax and w/o COMPAT50 it understands only the new syntax.

So far I understand your point, COMPAT50 should be on by default
and I can create the new /dev/pci for all busses but have to keep all the old 
ones for backward compatibility. Is this correct?

Christoph