Re: pkgsrc RC scripts

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sun, Oct 18, 2009 at 11:24:11PM -0400, Matthew Mondor wrote:
> On Mon, 19 Oct 2009 03:58:42 +0100
> Alistair Crooks <agc%pkgsrc.org@localhost> wrote:
> 
> > On Sun, Oct 18, 2009 at 10:54:33PM -0400, Matthew Mondor wrote:
> > > while (isspace((int)*value))
> > >         value++;
> > 
> > I'm missing why you would bother casting to (int) in the ctype
> > macro arg here.
> 
> with -Wall:
> 
> warning: array subscript has type 'char'

Indeed.  It might be better to fix the problem at source, since the
cast we make in NetBSD is to (unsigned char), to avoid negative array
indexing (where ctype macros are implemented using arrays).

Regards,
Alistair