Re: mounting wedges by name

[christos%astron.com@localhost (Christos Zoulas)]

In article <i9f757$j34$1%serpens.de@localhost>,
Michael van Elst <mlelstv%serpens.de@localhost> wrote:
>christos%astron.com@localhost (Christos Zoulas) writes:
>
>>Looks good:
>
>>- you could make the mib array static const.
>
>The other uses (say in vmstat) all initialize an auto array.

So if it is done poorly shouldn't we improve it?

>>- there are some missing spaces after commas.
>>- I prefer to write the strtok loops:
>>      for (p = strtok(array, " "); p; p = strtok(NULL, " "))
>
>That's just copy&paste from another such loop in the same file.

Again.

>>- I think you really need to use iconv instead of casting the utf8 and using
>>  strcmp.
>
>I had some private discussion about this. Pathnames aren't
>interpreted according to locale, why should partition names
>be different? Also, there could be partition names that have no
>valid representation in the current locale.
>
>How would iconv impact say /rescue/mount ?

Now that I think about it is perhaps better not to use iconv here.

christos