tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: New library addition



> I am about to add libperfuse and perfused to the base system (hey have
> been in tree for a while but were not built). Adding a new library to
> the sets lists is not straightforward, it would be nice if someone could
> review that change.
> 
> http://ftp.espci.fr/shadow/manu/perfuse.patch

src/lib/libperfuse/Makefile:
 - needs RCSId
 - PERFUSE_OPT_DEBUG_FLAGS should be enabled only .ifdef DEBUG
   as librefuse does?

src/distrib/sets/lists/comp/mi:
 - ./usr/libdata/debug/usr/sbin/perfused.debug is also required for MKDEBUG?

src/usr.sbin/perfused/Makefile (not in patch)
 - needs RCSId
 - PERFUSE_OPT_DEBUG_FLAGS should be enabled only .ifdef DEBUG ?
 - should use "CFLAGS+=", not "CFLAGS=" ?
 - LDADD seems to have extra stuff 

It would also be worth to check results of sun2 (i.e. MKPIC=no) builds
on releng after commit.
---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index