tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Adding missing __printflike attributions



On Sun, 04 Mar 2012, Julio Merino wrote:
For files within atf, please do:

ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF(2, 3)

Ow!  Why yet another way to say the same thing?

Because attributes are not portable across compilers and atf is supposed to work on different platforms?

Portability is one of the reasons why we use __printflike instead of __attribute__((__format__(whatever))). Readability is another reason.

You can define __printflike differently for different compilers just as easily as you can define ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF differently for different compilers, so ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF·does not seem to have any advantage.

--apb (Alan Barrett)


Home | Main Index | Thread Index | Old Index