Re: tgamma(3) from FreeBSD

[christos%astron.com@localhost (Christos Zoulas)]

In article <4FA454E4.2010605%eq.cz@localhost>, rudolf  <netbsd%eq.cz@localhost> 
wrote:
>Christos Zoulas wrote:
>> In article<4FA4249C.7000708%eq.cz@localhost>, rudolf<netbsd%eq.cz@localhost> 
>>  wrote:
>[...]
>>> http://software.eq.cz/tgamma.diff.txt
>[...]
>>> Please let me know if there are any issues with the import, I'd like to
>>> find this function in the upcoming NetBSD 6.0 release.
>>
>> In b_log.c
>>      s/static double/static const double/ where appropriate.
>>      kill _ANSI_SOURCE
>> In b_tgamma.c
>>      ansify
>>
>> mathimpl.h could be absorbed in math_private.h
>
>Thanks for your reply. Here is new version:
>http://software.eq.cz/tgamma_v2.diff.txt
>
>I've also removed the "#if 0"-ed code 
>(http://grok.x12.su/source/xref/freebsd/lib/msun/bsdsrc/b_exp.c#88) and 
>s/#include <math.h>/#include "math.h"/. Is it right?
>

Thanks, looks good:
1. Add /* $NetBSD$ */ as the first line in the file
2. function name definitions should start at column 1 as:

type
name(type param)

not as:

type name(type param)

Change those and commit it.

christos