Re: liblzf incompatibility

[Thor Lancelot Simon <tls%panix.com@localhost>]

On Wed, Aug 29, 2012 at 07:32:02AM +0000, Christos Zoulas wrote:
> In article <20120828194151.BB89014A37A%mail.netbsd.org@localhost>,
> Mindaugas Rasiukevicius  <rmind%netbsd.org@localhost> wrote:
> >yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> >> hi,
> >> 
> >> > hi,
> >> > 
> >> >> On Mon, Jun 11, 2012 at 11:45:11PM -0400, Thor Lancelot Simon wrote:
> >> >>> On Tue, Jun 12, 2012 at 01:58:12AM +0000, YAMAMOTO Takashi wrote:
> >> >>> > hi,
> >> >>> > 
> >> >>> > is there a near-future plan to use liblzf for any in-tree stuff?
> >> >>> > otherwise i'd suggest to disable it because it only causes problems.
> >> >>> > see PR/46426.
> >> >>> 
> >> >>> I have code that uses it, both in userspace and the kernel, but I
> >> >>> never checked it in because I ran into a build problem with
> >> >>> src/common.  Let me see what I can do about both issues.
> >> 
> >> any progress?
> >> 
> >> if you don't want to remove it, how about renaming it?
> >
> >I think this ought to be removed from netbsd-6 (incompatible and there are
> >no users, nor there is going to be as we are in RC1) and at the very least
> >disabled in -current.
> 
> Or just make it compatible and add _s functions that pass the state. Or
> make it detect NULL state and provide the one on the stack.

I was going to do the former.  But I am intrigued by the possibility of
the latter -- is it really portable?

Thor