tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/44246: enhance mv to work better with xargs



David Holland writes:
- On Sat, Jan 12, 2013 at 08:21:59PM -0600, Eric Schnoebelen wrote:
-  > -  for (rval = 0; --argc; ++argv) {
-  > +  for (rval = 0; argc--; argv++) {
- 
- Can you change that to a normal for (i=1; i<argc; i++) type of loop?

Sure, I was just going for the minimal number of changes..

- Custom loop logic always worries passersby... and this particular diff
- really looks wrong even though I'm pretty sure it isn't.

The change was required to make everything work.  but I'll make
it less obtuse.

- Other than that, seems like a fine idea to me.

Thanks,
        Eric

--
Eric Schnoebelen                eric%cirr.com@localhost         
http://www.cirr.com
        "...I knew I was working way too hard when I started having 
                nightmares in FORTRAN" -- Brent Chapman


Home | Main Index | Thread Index | Old Index