Re: Patch from FreeBSD for el_gets() in libedit

[christos%astron.com@localhost (Christos Zoulas)]

In article <5559176C.7000500%defora.org@localhost>,
Pierre Pronchery  <khorben%defora.org@localhost> wrote:
>-=-=-=-=-=-
>
>			Hi tech-userlevel@,
>
>FreeBSD patched their own copy of libedit about a month ago, see:
>https://svnweb.freebsd.org/ports/head/devel/libedit/files/patch-src_eln.c?revision=382458&view=markup
>(patch attached)
>
>If I get this right (I have never used libedit myself) the value
>returned in the "nread" argument (called "count" in the corresponding
>manual page) may be wrong if any wide-character was encountered.

Yes, I just fixed it.

>I did not find where el_wgets() is implemented. Would anyone know?

it is in read.c (el,gets).

>In pkgsrc I saw a folder called "libedit" in net/tnftp/files/libedit,
>and it has a completely different implementation of el_gets().

I don't know, perhaps an older version.

>Ok to commit?

Does not work properly if el_wgets() got an error. See what I committed.

Thanks for noticing,

christos