New DTrace code - build issues

[Kamil Rytarowski <n54%gmx.com@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Thank you Christos for your work on DTrace!

I'm having problems building it, the log is attached to the mail.

- From what I saw, there is a type mismatch:

typedef struct {
        uint8_t data[PTRACE_BREAKPOINT_SIZE];
} proc_breakpoint_t;

vs

ulong_t dbp_instr;              /* saved instruction from breakpoint */

At the moment I'm unsure about the correct translation between these
types.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWBdzNAAoJEEuzCOmwLnZs9GYP/1OGmLru49i7WpLPxrZmCnzm
PfV7AnW4C7628RkUMbYNIpge+O9OFdAuWZoxfANz44JIP6VW6Rnf/d8ZYj8ut5Nk
4E5Sl/HS8TdTrscfLWEiiAf3suYQdnwRPFEG+VjNcrj5+TPYvMmyFGOYh7o6JTSE
Mq7tEh11sRTm4r9wy2JmJHESpwsW09G1B+N1VgG7LoIzSwt2B0mnBlg92zEMGh1I
8zMVK+CJx8TPJ3Dl/ZYysHV/ctaapPzF6PvTe0CedXpQWEOy6sume0kS2dmqqnCg
8SFUfEyPHj/cDtLRSvYUQuaNgEKUHWiTPOnORogszyJaJdjCaRNwaxeVa3tPfCbH
Qs6KGUdyfHhVDmJKzMTKYaImQc2oelXYAZPVkHKD7WakgkeGniZep5zxUYUSJ7cD
PLHxkTp9x37AhUuDbdLeEwoy/0suEgHSfJXJ4uUNauNSPhBwe1zPtGlCAB3Gf1U6
5itYrBfcIkuOuN5T+i9T8F9FA+uK0/48bdVENOBh5YUg97bnq2mKDs3xbX6p1FBH
qpZrBv1ki2uduJiR6w/IplZSb8xNhpqlGmAMF92JZjAj8jXH2NrutwogOOIkuDTd
FcB/Cd3rfE15cWS8jvqNQeblawNdS6tlzDh+jAeoiMAMA7AOsHTR+pL1vk3e5w+U
wOcrl1aTIWaznGnkp67n
=ZZA3
-----END PGP SIGNATURE-----

install ===> lib/../external/bsd/libevent/lib/libevent_openssl
install ===> lib/../external/bsd/libevent/lib/libevent_pthreads
install ===> lib/../external/bsd/libproc/lib
install ===> lib/../external/bsd/fetch/lib
install ===> lib/../external/gpl3/gcc.old/lib/libasan
dependall-../external/bsd/bind/lib ===> lib     (with: dependall-../external/cddl/osnet/lib/libdtrace dependall-librumpdev dependall-librumpnet dependall-librumpvfs dependall-../crypto/external/bsd/libsaslc dependall-../external/bsd/mdocml/lib)
dependall ===> lib/../external/cddl/osnet/lib/libdtrace
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpcreate':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:118:3: error: passing argument 3 of 'proc_bkptset' from incompatible pointer type [-Werror]
   if (Psetbkpt(P, dbp->dbp_addr, &dbp->dbp_instr) == 0)
   ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:155:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t *'
 int proc_bkptset(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpdestroy':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:139:8: error: passing argument 3 of 'proc_bkptdel' makes pointer from integer without a cast [-Werror]
        dbp->dbp_addr, dbp->dbp_instr);
        ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:156:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptdel(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpmatch':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:189:2: error: passing argument 2 of 'proc_bkptexec' makes pointer from integer without a cast [-Werror]
  (void) Pxecbkpt(dpr->dpr_proc, dbp->dbp_instr);
  ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:158:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptexec(struct proc_handle *, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpenable':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:202:7: error: passing argument 3 of 'proc_bkptset' from incompatible pointer type [-Werror]
       dbp->dbp_addr, &dbp->dbp_instr) == 0)
       ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:155:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t *'
 int proc_bkptset(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpdisable':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:219:7: error: passing argument 3 of 'proc_bkptdel' makes pointer from integer without a cast [-Werror]
       dbp->dbp_addr, dbp->dbp_instr) == 0)
       ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:156:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptdel(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpcreate':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:118:3: error: passing argument 3 of 'proc_bkptset' from incompatible pointer type [-Werror]
   if (Psetbkpt(P, dbp->dbp_addr, &dbp->dbp_instr) == 0)
   ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:155:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t *'
 int proc_bkptset(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpdestroy':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:139:8: error: passing argument 3 of 'proc_bkptdel' makes pointer from integer without a cast [-Werror]
        dbp->dbp_addr, dbp->dbp_instr);
        ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:156:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptdel(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpmatch':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:189:2: error: passing argument 2 of 'proc_bkptexec' makes pointer from integer without a cast [-Werror]
  (void) Pxecbkpt(dpr->dpr_proc, dbp->dbp_instr);
  ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:158:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptexec(struct proc_handle *, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpenable':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:202:7: error: passing argument 3 of 'proc_bkptset' from incompatible pointer type [-Werror]
       dbp->dbp_addr, &dbp->dbp_instr) == 0)
       ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:155:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t *'
 int proc_bkptset(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c: In function 'dt_proc_bpdisable':
/usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:219:7: error: passing argument 3 of 'proc_bkptdel' makes pointer from integer without a cast [-Werror]
       dbp->dbp_addr, dbp->dbp_instr) == 0)
       ^
In file included from /usr/src/external/cddl/osnet/include/libproc.h:57:0,
                 from /usr/src/external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.h:32,
                 from /usr/src/external/cddl/osnet/lib/libdtrace/../../dist/lib/libdtrace/common/dt_proc.c:88:
/tmp/netbsd-tmp/destdir.amd64/usr/include/libproc.h:156:5: note: expected 'struct proc_breakpoint_t *' but argument is of type 'ulong_t'
 int proc_bkptdel(struct proc_handle *, uintptr_t, proc_breakpoint_t *);
     ^
cc1: all warnings being treated as errors
--- dt_proc.po ---
*** [dt_proc.po] Error code 1
nbmake[6]: stopped in /usr/src/external/cddl/osnet/lib/libdtrace
cc1: all warnings being treated as errors
--- dt_proc.pico ---
*** [dt_proc.pico] Error code 1
nbmake[6]: stopped in /usr/src/external/cddl/osnet/lib/libdtrace
2 errors
nbmake[6]: stopped in /usr/src/external/cddl/osnet/lib/libdtrace
--- dependall ---
*** [dependall] Error code 2

nbmake[5]: stopped in /usr/src/external/cddl/osnet/lib/libdtrace
1 error

nbmake[5]: stopped in /usr/src/external/cddl/osnet/lib/libdtrace
*** Failed target:  dependall-../external/cddl/osnet/lib/libdtrace
*** Failed command: _makedirtarget() { dir="$1"; shift; target="$1"; shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .) this="lib/"; real="/usr/src/lib" ;; *) this="lib/${dir}/"; real="/usr/src/lib/${dir}" ;; esac; show=${this:-.}; echo "${target} ===> ${show%/}${1:+ (with: $@)}"; cd "${real}" && /tmp/netbsd-tmp/tooldir.NetBSD-7.99.21-amd64/bin/nbmake _THISDIR_="${this}" "$@" ${target}; }; _makedirtarget ../external/cddl/osnet/lib/libdtrace dependall
*** Error code 2
Stop.
nbmake[4]: stopped in /usr/src/lib
--- build_install ---
*** [build_install] Error code 1
nbmake[3]: stopped in /usr/src/lib
1 error
nbmake[3]: stopped in /usr/src/lib
--- do-lib ---
*** [do-lib] Error code 2

nbmake[2]: stopped in /usr/src
1 error

nbmake[2]: stopped in /usr/src
--- build ---
*** [build] Error code 2

nbmake[1]: stopped in /usr/src
1 error

nbmake[1]: stopped in /usr/src
--- distribution ---
*** [distribution] Error code 2

nbmake: stopped in /usr/src
1 error

nbmake: stopped in /usr/src

ERROR: Failed to make distribution
*** BUILD ABORTED ***