Re: Replacing __BEGIN_DECLS in curses

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wed, Jan 04, 2017 at 02:38:16PM +0100, Thomas Klausner wrote:
> On Wed, Jan 04, 2017 at 01:56:21PM +0100, Joerg Sonnenberger wrote:
> > On Wed, Jan 04, 2017 at 11:44:03AM +0000, Roy Marples wrote:
> > > One such change is replacing __BEGIN_DECLS and __END_DECLS with expanded
> > > macros like
> > > #ifdef cplusplus
> > > extern "C" {
> > > #endif
> > > 
> > > Which is a lot more portable and very standard.
> > > Suggested patch to curses, forms and panel attached.
> > > Commentary welcome.
> > 
> > Please don't. This is clearly a regression for the headers.
> 
> Why is it a regression?

It makes things less readable and we actually go to some length to make
sure that our headers are friendly to default-hidden visibility (*cough*
Firefox *cough*).

Joerg