On 05.03.2018 07:21, Rin Okuyama wrote: > Hi, > > On 2018/03/05 3:29, Kamil Rytarowski wrote: >> I've been testing reg*sub(3) functions and I've noted that the >> USE_LIBTRE=yes build option no longer works: >> ... >> >> Do we intend to keep supporting it as a drop-in replacement >> implementation? > > IMO, TRE is not mature enough to be imported to libc. > > I attempt to replace a wchar_t-capable regex in nvi with TRE. Since the > upstream has been inactive for recent years, I tried to sync our version > with that in musl libc: > > https://git.musl-libc.org/cgit/musl/tree/src/regex > > Then I found many inappropriate uses of integer types. IIRC, int is used > here and there where size_t or regoff_t (aka int64_t) should be used. > They are partially corrected by musl libc (and by our own), but it seems > far from complete; it would require a full code review. Then, I've > suspended my initial plan. This is my current status with TRE... > > Thanks, > rin I will drop the USE_LIBTRE option, the only user is in lib/libc/Makefile and it does not build. Rationale: this 3rd party regex(3) is not actively maintained by anybody, and not ready as a drop-in replacement.
Attachment:
signature.asc
Description: OpenPGP digital signature