Re: installboot option for u-boot bootloader paths

[Simon Burge <simonb%NetBSD.org@localhost>]

Hi Brook,

Brook Milligan wrote:

> Installboot can install U-Boot boot blocks directly into a
> system image.  Normally, the U-Boot files are searched for in
> /usr/pkg/share/u-boot, under the expectation that most people will
> build them with pkgsrc.  However, it is also possible to set an
> environment v ariable to a colon-separated search path to accommodate
> other situations.
>
> I would like to add a command line option (tentatively -u) to set the
> search path and o verride the environment or default.
>
> Please see the attached patch.  I would appreciate comments and
> improvements.

Looks good!  My only comment is to not reference evbarm here

> Index: usr.sbin/installboot/installboot.8
>     ...
> +This option is only used on platforms that support
> +using
> +.Sy U-boot :
> +.Sy evbarm .
> +.

and

> Index: usr.sbin/installboot/installboot.h
>     ...
> +	const char	*uboot_paths;	/* u-boot paths (evbarm) */

Potentially this might be used for other archs in the future - some of
the RISC-V boot loaders support reading U-Boot from the boot media.

Cheers,
Simon.