Re: CVS commit: src/lib/libc/ssp

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wednesday, November 15, 2023 3:20:45 PM CET Christos Zoulas wrote:
> On 2023-11-14 10:31 pm, Jörg Sonnenberger wrote:
> > On Wednesday, November 15, 2023 4:15:28 AM CET you wrote:
> 
> > The functions are supposed to be transparent and they used to be. Can 
> > we
> > please just go back to the working state before? IMO wanting to 
> > overriding
> > getcwd is absolutely no justification for this. If the prototype (and 
> > inline
> > function) is visible from the header, userland should *not* be abled to
> > interpose it. If it is not visible due to standard headers, there was 
> > no
> > problem in first place.
> 
> Before I go and revert, can we have a consensus if the state is better 
> now
> or before? From my PoV the changes add some complexity, but they fix
> the original problem (overriding getcwd) in the PR.

It shouldn't be revelant that the libc symbol is weak. If you get the prototype from
the system headers, the symbol should be considered owned by libc, unless explicitly
agreed. I'd argue that the only interface we explicitly allow to interpose is malloc
for historic reasons.

Joerg