Subject: Re: NetBSD master CVS tree commits
To: None <darrenr@vitruvius.arbld.unimelb.edu.au>
From: Mike Long <mike.long@analog.com>
List: current-users
Date: 03/15/1996 13:44:45
[moved to current-users from source-changes]

>From: Darren Reed <darrenr@vitruvius.arbld.unimelb.edu.au>
>Date: Thu, 14 Mar 1996 05:19:40 +1000 (EST)

>>    Modified Files:
>>    	files files.oldconf 
>>    Log Message:
>>    Now need bpfilter for ppp, since it does packet filtering.
>>    Add files for PPP-Deflate packet compression support.

>No, I think what this is about is tcpdump wouldn't attach to a ppp device.
>This is a worthwhile change, unless you can construct BPF filters for
>compressed PPP data :-)

I haven't looked at the code yet (can't until I sup it), but why
didn't you just wrap the BPF function calls in if_ppp.c (or wherever)
with:

#include "bpf.h"
#if NBPF > 0
...
#endif

like all of the other network interface drivers?

I also think that kernel support for PPP-deflate, etc., should be
optional.  My ISP's Livingston Portmasters don't support PPP
compression (other than VJ header comp.), so I can't use it anyway.
-- 
Mike Long <mike.long@analog.com>     <URL:http://www.shore.net/~mikel>
VLSI Design Engineer         finger mikel@shore.net for PGP public key
Analog Devices, CPD Division          CCBF225E7D3F7ECB2C8F7ABB15D9BE7B
Norwood, MA 02062 USA       (eq (opinion 'ADI) (opinion 'mike)) -> nil