Subject: fingerd.c question
To: None <current-users@NetBSD.ORG>
From: Dave Burgess <burgess@cynjut.neonramp.com>
List: current-users
Date: 05/29/1996 22:55:27
I was playing around with the finderd sources and noticed something odd.
The definition of getpeername() used in the (currently unused) LOGGING
code segment calls for a "sockaddr_in sin" as the second argument to
getpeername().  The getpeername() man page says that the second argument 
should be a sockaddr structure.  Since the code is 'not yet' code, it 
isn't a big deal, but wouldn't it be a good idea to have the includes 
and the functions in this section at least agree with the current man 
pages?  

A different suggestion would be to simply remove this segment (the
#ifdef LOGGING stuff) altogether.  There doesn't seem to be a lot of
drive for using the logging feature, and the code segment seems to be
wrong from top to bottom.

I'm not suggesting that this be a sudden 'stop the presses' issue,
especially with the release of 1.2 getting ready to roll out.  I just
thought I'd kind of 'document' it.
-- 
Dave Burgess  (The man of a thousand E-Mail addresses)
386bsd FAQ Maintainer / SysAdmin for the NetBSD system in my spare bedroom
"Just because something is stupid doesn't mean that there isn't someone
that wants to do it...."