Subject: Re: check_DESTDIR again..
To: Patrick Welche <prlw1@newn.cam.ac.uk>
From: Luke Mewburn <lukem@wasabisystems.com>
List: current-users
Date: 03/19/2002 22:02:13
On Mon, Mar 18, 2002 at 06:35:15PM +0000, Patrick Welche wrote:
| On Sat, Mar 16, 2002 at 07:54:15PM +0000, Patrick Welche wrote:
| > cd /usr/src/etc
| > make -n DESTDIR=/ distrib-dirs
| >
| > On i386, all OK. On acorn32,
| >
| > make: don't know how to make check_DESTDIR. Stop
| >
| > Yet, both use the same nfs exported /usr/src, and did remake make, and
| > install /usr/share/mk on the acorn32 - afterall check_DESTDIR is now
| > defined in bsd.own.mk, so I don't see what the difference is!
|
| Answer: acorn32 has USETOOLS=no. Trying on i386 with USETOOLS=no gives the
| same error => all builds with USETOOLS=no fail as check_DESTDIR is not
| defined in .ALLTARGETS, yet all builds look for check_DESTDIR.
|
| It turns out this is because of a cunningly hidden .endif in bsd.own.mk, and
| the following patch seems to fix it:
good call, but not exactly the correct fix. ;-) your patch effectively
made check_DESTDIR a no-op, because DESTDIR would have been defined
beforehand.
i've committed a fix which should fix the problem.
luke.