Subject: minor error-handling buglet in checkflist
To: None <current-users@netbsd.org>
From: Greg Troxel <gdt@ir.bbn.com>
List: current-users
Date: 02/10/2004 12:27:28
I ran 'build.sh sets' without having done a 'release', thinking that
sets would imply release.  This was simply my error (I started with no
tools, no obj and no destdir), and I'm not complaining that I lost.

But it lost in an interesting way.  After failing to cd to the right
destdir.i386 (since it wasn't there), it checked flist against the
contents of src/distrib/sets.  Perhaps line 87 of checkflist needs to
say

 (cd $DESTDIR || (echo "NO DESTDIR - FAILURE"; exit 1))

instead.


===> build.sh command: ./build.sh -O /usr/obj/sinew-netbsd-current sets
===> build.sh started: Tue Feb 10 11:51:07 EST 2004
===> No nonexistent/bin/nbmake, needs building.
===> Bootstrapping nbmake
[make build elided]
cc  -O -o nbmake *.o  
#    objdir  /usr/obj/n0/gdt/SINEW-current/netbsd/src/tools
===> MACHINE:          i386
===> MACHINE_ARCH:     i386
===> TOOLDIR path:     /usr/obj/tools
===> DESTDIR path:     /usr/obj/sinew-netbsd-current/destdir.i386
===> RELEASEDIR path:  /usr/obj/sinew-netbsd-current/releasedir
===> Created /usr/obj/tools/bin/nbmake
===> makewrapper:      /usr/obj/tools/bin/nbmake-i386
===> Updated /usr/obj/tools/bin/nbmake-i386
===> Building sets from pre-populated /usr/obj/sinew-netbsd-current/destdir.i386
(cd /n0/gdt/SINEW-current/netbsd/src/distrib/sets && /usr/obj/tools/bin/nbmake sets)
#   execute  checkflist
/usr/obj/tools/bin/nbmake checkflist
cd /n0/gdt/SINEW-current/netbsd/src/distrib/sets &&  DESTDIR=/usr/obj/sinew-netbsd-current/destdir.i386  MACHINE=i386 MACHINE_ARCH=i386  CKSUM=/usr/obj/tools/bin/nbcksum MAKE=/usr/obj/tools/bin/nbmake MTREE=/usr/obj/tools/bin/nbmtree  MKTEMP=/usr/obj/tools/bin/nbmktemp PAX=/usr/obj/tools/bin/nbpax HOST_SH=sh  sh ./checkflist    
cd: can't cd to /usr/obj/sinew-netbsd-current/destdir.i386

============  448 extra files  ===============
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
------------------------------------------
./CVS
./CVS/Entries
./CVS/Entries.Log
./CVS/Repository
./CVS/Root
./Makefile
[lots]
./versions
=========  end of 448 extra files  ===========


===========  17253 missing files  ==============
Files in flist but missing from DESTDIR.
File wasn't installed ?
------------------------------------------
./.cshrc
./.profile
[lots]
./var/yp/Makefile.main
./var/yp/Makefile.yp
./var/yp/binding
========  end of 17253 missing files  ==========


*** Failed target:  checkflist
*** Failed command: cd /n0/gdt/SINEW-current/netbsd/src/distrib/sets && DESTDIR=/usr/obj/sinew-netbsd-current/destdir.i386 MACHINE=i386 MACHINE_ARCH=i386 CKSUM=/usr/obj/tools/bin/nbcksum MAKE=/usr/obj/tools/bin/nbmake MTREE=/usr/obj/tools/bin/nbmtree MKTEMP=/usr/obj/tools/bin/nbmktemp PAX=/usr/obj/tools/bin/nbpax HOST_SH=sh sh ./checkflist 
*** Error code 1

Stop.
nbmake: stopped in /n0/gdt/SINEW-current/netbsd/src/distrib/sets

*** Failed target:  maketarsetup
*** Failed command: /usr/obj/tools/bin/nbmake checkflist
*** Error code 1

Stop.
nbmake: stopped in /n0/gdt/SINEW-current/netbsd/src/distrib/sets

*** Failed target:  sets
*** Failed command: (cd /n0/gdt/SINEW-current/netbsd/src/distrib/sets && /usr/obj/tools/bin/nbmake sets)
*** Error code 1

Stop.
nbmake: stopped in /n0/gdt/SINEW-current/netbsd/src

ERROR: Failed to make sets
*** BUILD ABORTED ***