Subject: Re: Broken kern_todor.c
To: Havard Eidnes <he@uninett.no>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: current-users
Date: 09/12/2006 07:28:35
Havard Eidnes wrote:
>> Thats really, really weird, since since todr_debug is either a function,
>> or is a macro. I've test compiled this both ways for architectures
>> other than hpcarm. I'll do an hpcarm compile and see if it is busted.
>>
>
> Only if the port defines __HAVE_GENERIC_TODR. Look later in your
> mailbox; I've already sent you a note about this. ;-)
>
> One possible diff is
>
> Index: kern_todr.c
> ===================================================================
> RCS file: /u/nb/src/sys/kern/kern_todr.c,v
> retrieving revision 1.17
> diff -u -r1.17 kern_todr.c
> --- kern_todr.c 12 Sep 2006 05:47:47 -0000 1.17
> +++ kern_todr.c 12 Sep 2006 09:35:16 -0000
> @@ -274,6 +274,8 @@
> printf("Cannot set TOD clock time\n");
> }
>
> +#else
> +#define todr_debug(prefix, rv, dt, tvp)
> #endif /* __HAVE_GENERIC_TODR */
>
>
> Regards,
>
> - Håvard
>
I've fixed it. The better solution was to move definitions for
todr_debug out from inside the __HAVE_GENERIC_TODR test. Thanks, and sorry.
--
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134 Fax: 951 325-2191