Subject: Re: lfs_cleanerd doesn't compile
To: Kurt Schreiner <ks@ub.uni-mainz.de>
From: Andrew Doran <ad@netbsd.org>
List: current-users
Date: 10/08/2007 22:44:20
Hi Kurt,
On Mon, Oct 08, 2007 at 11:28:13PM +0200, Kurt Schreiner wrote:
> with sources cvs update'd some minutes ago I see the following
> problem:
>
> # compile lfs_cleanerd/lfs.o
> /u/NetBSD/arch/i386/TOOLS/bin/i386--netbsdelf-gcc -O2 -pipe -mfpmath=sse -msse2 -march=pentium-m -fstack-protector -Wstack-protector --param ssp-buffer-size=1 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Werror -I/u/NetBSD/src/sbin/fsck_lfs -nostdinc -isystem /u/NetBSD/arch/i386/dest/usr/include -D_FORTIFY_SOURCE=2 -c /u/NetBSD/src/sbin/fsck_lfs/lfs.c
> /u/NetBSD/src/sbin/fsck_lfs/lfs.c: In function 'lfs_valloc':
> /u/NetBSD/src/sbin/fsck_lfs/lfs.c:869: error: too many arguments to function 'brelse'
> /u/NetBSD/src/sbin/fsck_lfs/lfs.c: In function 'extend_ifile':
> /u/NetBSD/src/sbin/fsck_lfs/lfs.c:927: error: too many arguments to function 'brelse'
>
> *** Failed target: lfs.o
>
> In lines 869 and 927 above the macro LFS_GET_HEADFREE defined in
> src/sys/ufs/lfs/lfs.h is called where the kernelland "brelse(BP, 0)" is
> necessary, but in userland "brelse(bp)" as defind in
> src/sbin/fsck_lfs/bufcache.c has to be used, if I interpret the code
> correctly. Something like the following patch should do the trick:
> (at least everthing seems to compile... ;-)
That's pure evil.. Fixed, it should compile now.
Thanks,
Andrew