Re: Recent changes to make breaking tools?

[David Holland <dholland+netbsd%eecs.harvard.edu@localhost>]

On Fri, Feb 15, 2008 at 04:06:17AM -0800, Paul Goyette wrote:
 > I just updated sources a few minutes ago and tried to do a 'build.sh
 > release' for both port-amd64 and port-i386.  In both cases, as soon as 
 > build.sh tried to install an updated copy of texinfo, nbmake dropped 
 > core.  There doesn't seem to be any symbols around for nbmake (or at 
 > least I can't find them) but here's the backtrace.

Does the same thing happen if you just fire off nbmake by hand in
texinfo, or does it require being run from build.sh? If the former,
rebuild nbmake with DBG=-g (or whatever the magic incantation is)...

 > Core was generated by `nbmake'.
 > Program terminated with signal 10, Bus error.
 > #0  0x0000000000409bc3 in JobDoOutput ()

I fixed one bug in there late last night, but it was clear from
reports that there was still bad stuff going on somewhere. Knowing
that it's still in there will be helpful... unfortunately, I probably
can't look at it until tonight and hopefully someone else will fix it
before then.

There is, however, one other thing I noticed in there that's wrong. I
wouldn't expect it to be linked to the observed behavior, so it
probably won't help, but it can't hurt to try...

Index: job.c
===================================================================
RCS file: /cvsroot/src/usr.bin/make/job.c,v
retrieving revision 1.137
diff -u -r1.137 job.c
--- job.c       15 Feb 2008 08:55:31 -0000      1.137
+++ job.c       15 Feb 2008 15:28:18 -0000
@@ -1853,7 +1853,7 @@
        }
        if (i < max - 1) {
            /* shift the remaining characters down */
-           (void)memcpy(job->outBuf, &job->outBuf[i + 1], max - (i + 1));
+           (void)memmove(job->outBuf, &job->outBuf[i + 1], max - (i + 1));
            job->curPos = max - (i + 1);
 
        } else {

-- 
   - David A. Holland / dholland+netbsd%eecs.harvard.edu@localhost