Re: Cross-build failure on i386 in sh/init.c

[Patrick Welche <prlw1%newn.cam.ac.uk@localhost>]

On Thu, Feb 28, 2008 at 12:04:56PM +0200, Alan Barrett wrote:
> On Thu, 28 Feb 2008, Anthony Martinez wrote:
> > > Could you post a diff between the correct and incorrect versions of
> > > init.c? 
> > The unified diff is attached for preservation, though it really is just
> > one line.
> 
> OK.  Please try the following:
> 
> sh -c 'IFS="" ; echo " } " | ( read -r line ; echo \""${line}"\" )'
> 
> It's supposed to print " } " (with the spaces and quotation marks).  If
> some of the spaces are missing, then you have a shell bug.  This caused
> mkinit.sh to mistake the indented "}" in line 97 of output.c for the
> non-indented "}" that ends the "RESET" block.

While we're on shells... Here's another for our (pd)ksh:

% cat bit
foo=foo; t='[ ]'; case " foo bar " in *$t$foo$t*) echo yes;; esac
% sh bit
yes
% bash bit
yes
% ksh bit
% ksh -c 'echo $KSH_VERSION'
@(#)PD KSH v5.2.14 99/07/13.2

set -o posix doesn't affect the outcome...

Cheers,

Patrick