Re: No resume on Sony GRX690

["Jared D. McNeill" <jmcneill%invisible.ca@localhost>]

Ed Gould wrote:
> I'm running -current (4.99.72, today's sources) on a Sony Vaio 
> PCG-GRX690.  Suspend (via sysctl -w machdep.sleep_state=3) appears to 
> (mostly?) work, but the machine wil not resume.
>
> By mostly works, I mean that the machine appears to shut off (e.g., the 
> fan stops and the "on" light blinks yellow), but the screen does not go 
> off.  It does appear to dim some, though.
>
> Any thoughts on debugging this?  Any useful information to provide?

I suspected that I broke this... :/

Please try the following patch.

Index: acpi.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi.c,v
retrieving revision 1.119
diff -u -p -r1.119 acpi.c
--- acpi.c      10 Sep 2008 03:56:12 -0000      1.119
+++ acpi.c      15 Sep 2008 10:01:56 -0000
@@ -1273,11 +1273,11 @@ acpi_enter_sleep_state(struct acpi_softc
                } else {
                        int s = splhigh();
                        err = acpi_md_sleep(state);
+                       splx(s);
                        if (state == ACPI_STATE_S4)
                                AcpiEnable();
                        pmf_system_bus_resume(PMF_F_NONE);
                        AcpiLeaveSleepState((UINT8)state);
-                       splx(s);
                        pmf_system_resume(PMF_F_NONE);
                }