Re: Build tools broken - nbmake

[Eric Haszlakiewicz <erh%nimenees.com@localhost>]

On Mon, Dec 01, 2008 at 10:32:46AM -0800, Paul Goyette wrote:
> With big clue from cube@ I have applied the following patch, which seems 
> to make things work.
>       nvars = accumFor.nvars;
> -     accumFor.nvars = nvars + 1;
> +     accumFor.nvars = ++nvars;
>       accumFor.vars = bmake_realloc(accumFor.vars, nvars * sizeof(char *));

>       accumFor.vars = bmake_realloc(accumFor.vars, nvars * sizeof(char *));

er.. that's a rather screwey way of fixing the problem.  It would make a lot
more sense to do this instead:

>       int nvars;
> 
>       nvars = accumFor.nvars;
>       accumFor.nvars = nvars + 1;
>       accumFor.vars = bmake_realloc(accumFor.vars, accumFor.nvars * 
> sizeof(char *));   <--- change this line only: s/nvars/accumFor.nvars/
>       accumFor.vars[nvars] = make_str(data, len);
>  }

eric