Re: recent -current usr.bin/make changes break pkgsrc again

[David Laight <david%l8s.co.uk@localhost>]

On Sat, Jan 17, 2009 at 05:36:23PM +0100, Markus W Kilbinger wrote:
> Hi!
> 
> Recent (til todays) usr.bin/make changes seem to break pkgsrc usage
> again:
> 
>   # cd /usr/pkgsrc/www/firefox3 
>   # make cleandir
>   make: "../../mk/compiler/../../mk/compiler/gcc.mk" line 488: Malformed
>   conditional (!exists(${FCPATH}))
>   make: Fatal errors encountered -- cannot continue

Fixed....

I'm really not sure why it has ever worked!

pkgsrc/mk/gcc.mk tests .if exists(${FCPATH}) even though FCPATH is
likely to only be set if the file exists.

so:
    .if exists(${FCPATH}) => .if exists() => .ifdef exists(${FCPATH})
and the parser didn't include the ) in the argument.

Plausibly all of defined(), make(), exists(), target() and command()
should just return 'false'.

        David

-- 
David Laight: david%l8s.co.uk@localhost