Re: netbsd5-i386 is broken for me after this weekend's changes

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Nov 17, 2009 at 06:59:12AM -0800, Hisashi T Fujinaka wrote:
> >Could you try backing out the attached part of ticket #1129 ?
> >I think I got this part wrong; it calls vrelel but we didn't increase
> >v_usecount yet (at first glance the vrelel should be remplaced with
> >mutex_exit(&vp->v_interlock);)
> 
> Things are definitely hanging less, though I don't know how to exactly
> trigger/test my problems.

OK, thanks, this locates the problem.
I commited the attached patch to HEAD and will request a pullup; I think
this is the correct fix.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Index: vfs_subr.c
===================================================================
RCS file: /cvsroot/src/sys/kern/vfs_subr.c,v
retrieving revision 1.386
retrieving revision 1.387
diff -u -p -u -r1.386 -r1.387
--- vfs_subr.c  5 Nov 2009 08:18:02 -0000       1.386
+++ vfs_subr.c  17 Nov 2009 22:20:14 -0000      1.387
@@ -377,7 +377,7 @@ try_nextlist:
                 * Don't return to freelist - the holder of the last
                 * reference will destroy it.
                 */
-               vrelel(vp, 0); /* releases vp->v_interlock */
+               mutex_exit(&vp->v_interlock);
                mutex_enter(&vnode_free_list_lock);
                goto retry;
        }