Re: Enabling NX bit on Xen ports?

[Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>]

On Wed, 21 Apr 2010 10:58:42 +0200, Matthias Drochner
<M.Drochner%fz-juelich.de@localhost> wrote:
> jeanyves.migeon%free.fr@localhost said:
>> -#ifndef XEN
>>       if ((cpu_feature[2] & CPUID_NOX) && !(prot & VM_PROT_EXECUTE))
>> -             npte |= PG_NX;
>> -#endif
>> +             npte |= protection_codes[VM_PROT_EXECUTE];
>> +
> 
> This looks suspicious.

Thanks, fixed

> btw, both the diff and the commit message of amd64/mptramp.S
> are almost identical to rev. 1.2 of that file. How history
> repeats itself...

Hopefully, for the better.

Cheers,

-- 
Jean-Yves Migeon
jeanyves.migeon%free.fr@localhost