Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Build break - commaizenumber



On Tue, Mar 15, 2011 at 04:27:36PM +0100, Martin Husemann wrote:
> On Tue, Mar 15, 2011 at 04:21:37PM +0100, Joerg Sonnenberger wrote:
> > No. As I wrote on source-changes, if anything, it should be a flag to
> > humanize_number.

hmm... humanize_number is quite specific to turning a number into a number
and a prefix.  Shoehorning a flag (or flags) to turn off the regular behaviour
of humanize_number, and enable the commas seems like it wouldn't fit well.

(btw, I'm not on the source-changes list, and mail-index doesn't seem to have
your message yet)

> Huh? The printf behaviour seems to do be completely correct for this use
> case (modulo fixing some of our locale descriptions).

It sounds to me like the printf behaviour could be quite frustrating:
"I just told ls to display commas, but it's refusing to do so"

Especially so since the thousands separator isn't consistently set.  e.g.
the es locale sets it, but es_ES.UTF-8 doesn't.  ja_JP.UTF-8 sets it but 
ja doesn't.  etc...

eric


Home | Main Index | Thread Index | Old Index