Re: 2 extra files in DESTDIR

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Feb 21, 2014 at 03:29:53PM -0800, B Harder wrote:
> =======  2 extra files in DESTDIR  =========
> Files in DESTDIR but missing from flist.
> File is obsolete or flist is out of date ?
> ------------------------------------------
> ./usr/include/g++/complex.h
> ./usr/include/gcc-4.1
> =========  end of 2 extra files  ===========

To cite my mail from beginning of January:

On Sat, Jan 04, 2014 at 07:41:16PM +0100, Thomas Klausner wrote:
> I just saw this (not an update build) while building current-amd64
> with clang:
> 
>         Removed obsolete file 
> /archive/build/amd64.clang.20140104//usr/include/g++/complex.h
> 
> So it seems to me the build installs a file that's marked as obsolete.
 
I traced this back to this commit by christos:

1.1853       (christos 02-Nov-13): ./usr/include/g++/complex.h                  
comp-obsolete           gcc=45,obsolete
1.1853       (christos 02-Nov-13): ./usr/include/g++/complex.h                  
comp-obsolete           gcc=48,obsolete

revision 1.1853
date: 2013-11-02 02:37:33 +0100;  author: christos;  state: Exp;  lines: +3 -4; 
 commitid: GLHchWdlCEi5TDbx;
more sets fixes

@@ -1204,8 +1204,8 @@
 ./usr/include/g++/cmath                                comp-cxx-include        
gcc,cxx,libstdcxx
 ./usr/include/g++/compare.h                    comp-obsolete           obsolete
 ./usr/include/g++/complex                      comp-cxx-include        
gcc,cxx,libstdcxx
-./usr/include/g++/complex.h                    comp-obsolete           
gcc=45,cxx,libstdcxx
-./usr/include/g++/complex.h                    comp-obsolete           
gcc=48,cxx,libstdcxx
+./usr/include/g++/complex.h                    comp-obsolete           
gcc=45,obsolete
+./usr/include/g++/complex.h                    comp-obsolete           
gcc=48,obsolete
 ./usr/include/g++/condition_variable           comp-cxx-include        
gcc=45,cxx,libstdcxx
 ./usr/include/g++/condition_variable           comp-cxx-include        
gcc=48,cxx,libstdcxx
 ./usr/include/g++/csetjmp                      comp-cxx-include        
gcc,cxx,libstdcxx

Before that it was only:

1.1819       (joerg    28-Apr-13): ./usr/include/g++/complex.h                  
comp-obsolete           gcc=45,cxx,libstdcxx

until mrg added:

1.1852       (mrg      01-Nov-13): ./usr/include/g++/complex.h                  
comp-obsolete           gcc=48,cxx,libstdcxx

for

revision 1.1852
date: 2013-11-01 08:48:31 +0100;  author: mrg;  state: Exp;  lines: +622 -10;  
commitid: wvfrE2n2ze1fYxbx;
add support for GCC 4.8 sets.


I have build logs from Oct 31 where this didn't happen; my next build
was only on Nov 26.

I don't know what the idea here is, but something's wrong, please fix
it.
 Thomas