Re: port-amd64 build still broken - libzpool/dmu_objset.c

[Ryota Ozaki <ozaki-r%NetBSD.org@localhost>]

On Fri, Mar 28, 2014 at 9:36 PM, Paul Goyette <paul%whooppee.com@localhost> 
wrote:
> With sources from 2014-03-28 at 03:20:01 UTC (which includes the latest fix
> for libzpool/common/util.c) I am now seeing the following failure:

The error should be fixed by my fix committed at 03:46:56 UTC.

  ozaki-r

>
> #   compile  libzpool/dmu_objset.o
> /test-bed/tools/bin/x86_64--netbsd-gcc -O2 -O0 -fno-inline -std=gnu99
> --sysroot=/test-bed/dst "-D__va_list=va_list" "-Doffsetof(s,
> m)=((size_t)(&(((s *)0)->m)))" -std=c99 -D_SUNOS_VTOC_16
> -D_PROPLIB_ZFS_CONFLICT -I/test-bed/src/external/cddl/osnet
> -I/test-bed/src/external/cddl/osnet/include
> -I/test-bed/src/external/cddl/osnet/sys
> -I/test-bed/src/external/cddl/osnet/dist/uts/common
> -I/test-bed/src/external/cddl/osnet/dist/uts/common/zfs
> -I/test-bed/src/external/cddl/osnet/dist/uts/common/fs/zfs
> -I/test-bed/src/external/cddl/osnet/dist/uts/common/sys
> -I/test-bed/src/external/cddl/osnet/dist/common/zfs
> -I/test-bed/src/external/cddl/osnet/dist/head
> -I/test-bed/src/external/cddl/osnet/dist/lib/libdevinfo
> -I/test-bed/src/external/cddl/osnet/dist/lib/libnvpair
> -I/test-bed/src/external/cddl/osnet/dist/lib/libshare/common
> -I/test-bed/src/external/cddl/osnet/dist/lib/libumem
> -I/test-bed/src/external/cddl/osnet/dist/lib/libuutil/common
> -I/test-bed/src/external/cddl/osnet/dist/lib/libzfs/common
> -I/test-bed/src/external/cddl/osnet/dist/lib/libzpool/common
> -I/test-bed/src/external/cddl/osnet/dist/common -std=c99  -c
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c
> -o dmu_objset.o
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c:
> In function 'dmu_objset_open_impl':
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c:236:3:
> warning: passing argument 2 of 'snprintf_blkptr' makes pointer from integer
> without a cast [enabled by default]
>    dprintf_bp(os->os_rootbp, "reading %s", "");
>    ^
> In file included from
> /test-bed/src/external/cddl/osnet/dist/uts/common/fs/zfs/sys/dmu_objset.h:29:0,
>                  from
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c:28:
> /test-bed/src/external/cddl/osnet/dist/uts/common/fs/zfs/sys/spa.h:595:13:
> note: expected 'const struct blkptr_t *' but argument is of type 'int'
>  extern void snprintf_blkptr(char *buf, const blkptr_t *bp);
>              ^
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c:236:3:
> error: too many arguments to function 'snprintf_blkptr'
>    dprintf_bp(os->os_rootbp, "reading %s", "");
>    ^
> In file included from
> /test-bed/src/external/cddl/osnet/dist/uts/common/fs/zfs/sys/dmu_objset.h:29:0,
>                  from
> /test-bed/src/external/cddl/osnet/lib/libzpool/../../dist/uts/common/fs/zfs/dmu_objset.c:28:
> /test-bed/src/external/cddl/osnet/dist/uts/common/fs/zfs/sys/spa.h:595:13:
> note: declared here
>  extern void snprintf_blkptr(char *buf, const blkptr_t *bp);
>              ^
>
>
> -------------------------------------------------------------------------
> | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
> | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
> | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
> | Kernel Developer |                          | pgoyette at netbsd.org  |
> -------------------------------------------------------------------------