Re: recent dhcpcd looping on ppp0

[Roy Marples <roy%marples.name@localhost>]

On 2014-09-29 11:33, Roy Marples wrote:
> > > > Going to guess that ppp0 doesn't have a carrier status OR 
> > > > IFF_RUNNING set?
> > > > The attached patch should reduce the log spam, let me know how it 
> > > > works out.
> > > Errm, this patch should do better!
> > Well, less spam, but still
> >     - busy wait (repeated count goes up to ~300k)
> > Sep 28 23:50:05 Andromeda dhcpcd[1101]: ppp0: unknown carrier
> > Sep 28 23:50:05 Andromeda dhcpcd[1101]: ppp0: carrier_status:
> > Inappropriate ioctl for device
> > Sep 28 23:50:14 Andromeda syslogd[1251]: last message repeated 12776 
> > times
> >
> >     - a flurry of routing messages (probably same number of as syslog 
> > entries)
> > got message of size 152 on Sun Sep 28 23:50:10 2014
> > RTM_IFINFO: iface status change: len 152, if# 6, carrier: unknown,
> > flags: <UP,PTP,MULTICAST>
> > got message of size 152 on Sun Sep 28 23:50:10 2014
>
> Yes, these messages are being triggerd by a flurry of routing messages.
> This is probably a bug in NetBSD somewhere and the attached patch
> should pretty much silence the warnings down to one n dhcpcd until the
> link actually comes up.

So the flurry of messages is triggered by dhcpcd still (thanks 
jmcneill!).
This patch should fix it and all should now be well.

Roy

Index: dhcpcd.c
==================================================================
--- dhcpcd.c
+++ dhcpcd.c
@@ -552,14 +552,14 @@
 		break;
 	default:
 		ifp->flags = flags;
 	}
 
-	if (carrier == LINK_UNKNOWN)
-		syslog(LOG_ERR, "%s: carrier_status: %m", ifname);
-	/* IFF_RUNNING is checked, if needed, earlier and is OS dependant */
-	else if (carrier == LINK_DOWN || (ifp->flags & IFF_UP) == 0) {
+	if (carrier == LINK_UNKNOWN) {
+		if (errno != ENOTTY) /* For example a PPP link on BSD */
+			syslog(LOG_ERR, "%s: carrier_status: %m", ifname);
+	} else if (carrier == LINK_DOWN || (ifp->flags & IFF_UP) == 0) {
 		if (ifp->carrier != LINK_DOWN) {
 			if (ifp->carrier == LINK_UP)
 				syslog(LOG_INFO, "%s: carrier lost", ifp->name);
 			ifp->carrier = LINK_DOWN;
 			script_runreason(ifp, "NOCARRIER");
@@ -638,11 +638,10 @@
 {
 	struct interface *ifp = arg;
 	struct if_options *ifo = ifp->options;
 	size_t i;
 	char buf[DUID_LEN * 3];
-	struct timeval tv;
 
 	pre_start(ifp);
 	if (if_up(ifp) == -1)
 		syslog(LOG_ERR, "%s: if_up: %m", ifp->name);
 
@@ -653,20 +652,19 @@
 			break;
 		case LINK_DOWN:
 			syslog(LOG_INFO, "%s: waiting for carrier", ifp->name);
 			return;
 		case LINK_UNKNOWN:
-			/* No media state available, so we loop until
-			 * IFF_UP and IFF_RUNNING are set. */
+			/* No media state available.
+			 * Any change on state such as IFF_UP and IFF_RUNNING
+			 * should be reported to us via the route socket
+			 * as we've done the best we can to bring the interface
+			 * up at this point. */
 			ifp->carrier = if_carrier(ifp);
 			if (ifp->carrier != LINK_UNKNOWN)
 				goto link_retry;
 			syslog(LOG_INFO, "%s: unknown carrier", ifp->name);
-			tv.tv_sec = 0;
-			tv.tv_usec = 100;
-			eloop_timeout_add_tv(ifp->ctx->eloop, &tv,
-			    dhcpcd_startinterface, ifp);
 			return;
 		}
 	}
 
 	if (ifo->options & (DHCPCD_DUID | DHCPCD_IPV6)) {