Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

build fails for non-DIAGNOSTIC kernel with awingpio(4)



Hi,

Build fails for non-DIAGNOSTIC kernel with awingpio(4):

src/sys/arch/arm/allwinner/awin_gpio.c: In function 'awin_gpio_pin_irqen':
src/sys/arch/arm/allwinner/awin_gpio.c:937:37: error: unused variable 'grp' [-Werror=unused-variable]
  struct awin_gpio_pin_group * const grp = cookie;
                                     ^

This is because variable "grp" is only used as an argument for
KASSERT(9). Please apply the attached patch.

Thanks,
Rin

--- src/sys/arch/arm/allwinner/awin_gpio.c.orig	2016-05-24 05:30:34.804892232 +0900
+++ src/sys/arch/arm/allwinner/awin_gpio.c	2016-05-24 05:38:07.518505001 +0900
@@ -934,7 +934,9 @@
 static void
 awin_gpio_pin_irqen(void *cookie, int pin, bool enable)
 {
+#ifdef DIAGNOSTIC
 	struct awin_gpio_pin_group * const grp = cookie;
+#endif
 	uint32_t enabled;
 	struct awin_gpio_softc *sc = &awin_gpio_sc;


Home | Main Index | Thread Index | Old Index