Re: Recent amd64 auich panics

[Martin Husemann <martin%duskware.de@localhost>]

On Mon, Jan 23, 2017 at 08:33:34AM +0000, Chavdar Ivanov wrote:
> Hi,
> 
> The last few days I am getting repeated panics on amd64 -current running
> under VirtualBox (latest 5.1.14 version at the moment) as follows:
> ---
> panic: auidui_init_ringbuffer: blksize=0

There were some changes in this area yesterday which fixed a similar
problem for me, also this code probably needs fixing:

static int
auich_round_blocksize(void *v, int blk, int mode,
    const audio_params_t *param)
{

        return blk & ~0x3f;             /* keep good alignment */
}

It should return 0x40 instead of 0 for too small block sizes.
Something like:

	if (blk < 0x40)
		return 0x40;		/* avoid 0 block size */
	return blk & ~0x3f;             /* keep good alignment */

Martin