Aquantia AQC100 issues

[Andrius V <vezhlys%gmail.com@localhost>]

Hi,

Recently I received Asus XG-C100F SFP+ network controller based on
Aquantia AQC100. Though, it's currently supported by aq(4) driver, I
believe it should be relatively easy to add. I tried to blindly add
the device to the list and even made it work, unfortunately with some
caveats. To make work I need to boot into the system first and
physically reattach the cable (I am using DAC). Even if cable is
attached and system boots, media type is not recognized and reports as
if link is missing, unless I physically reattach it. After that it
properly configures and dhcpcd assigns IP address. I can successfully
access the network. Any ideas why I need to reattach the cable?

Another issue likely unrelated to the driver itself since I had
similar issues previously: if integrated gigabit ethernet is
configured during boot as well and I am trying to put it down
(ifconfig re0 down), aq0 also stops "working" along with it and I
can't find the way to make it work besides reboot and making sure re0
is not configured (similar issue I had without vte0 and axen0,
including much slower transfer speed for axen0, if both working at the
same time). By that I mean that I can't reach network (even if
configuration seems correct). ifconfig aq0 down/up or dhcpcd
release/renew doesn't help, usually it just reassigns to some internal
IP.

Applied patch:
diff --git a/sys/dev/pci/if_aq.c b/sys/dev/pci/if_aq.c
index 02bbffbad31..caf6c81d4d0 100644
--- a/sys/dev/pci/if_aq.c
+++ b/sys/dev/pci/if_aq.c
@@ -1142,6 +1142,10 @@ static const struct aq_product {
        enum aq_media_type aq_media_type;
        aq_link_speed_t aq_available_rates;
 } aq_products[] = {
+       { PCI_VENDOR_AQUANTIA, PCI_PRODUCT_AQUANTIA_AQC100,
+         "Aquantia AQC100 10 Gigabit Network Adapter",
+         AQ_MEDIA_TYPE_FIBRE, AQ_LINK_ALL
+       },
        { PCI_VENDOR_AQUANTIA, PCI_PRODUCT_AQUANTIA_AQC107,
          "Aquantia AQC107 10 Gigabit Network Adapter",
          AQ_MEDIA_TYPE_TP, AQ_LINK_ALL
diff --git a/sys/dev/pci/pcidevs b/sys/dev/pci/pcidevs
index 4baa7573e4e..55e33a0a164 100644
--- a/sys/dev/pci/pcidevs
+++ b/sys/dev/pci/pcidevs
@@ -1289,6 +1289,7 @@ product APPLE INTREPID2_GMAC      0x006b  Intrepid 2 GMAC
 product APPLE BCM5701          0x1645  BCM5701

 /* Aquantia Corp. */
+product AQUANTIA AQC100                0x00b1  AQC100 10 Gigabit
Network Adapter
 product AQUANTIA AQC107                0x07b1  AQC107 10 Gigabit
Network Adapter
 product AQUANTIA AQC108                0x08b1  AQC108 5 Gigabit Network Adapter
 product AQUANTIA AQC109                0x09b1  AQC109 2.5 Gigabit
Network Adapter

Regards,
Andrius V